Yeah, I think so. Doing it this way means every test needs to care about
this uglyness, doing the copy means only the generators need to care.


On Fri, Dec 20, 2013 at 9:55 PM, Paul Kehrer <notifications@github.com>wrote:

> In tests/hazmat/primitives/utils.py:
>
> > @@ -44,8 +44,8 @@ def encrypt_test(backend, cipher_factory, mode_factory, params, only_if,
> >                   skip_message):
> >      if not only_if(backend):
> >          pytest.skip(skip_message)
> > -    plaintext = params.pop("plaintext")
> > -    ciphertext = params.pop("ciphertext")
> > +    plaintext = params["plaintext"]
>
> So previously we had lambdas that frequently had args that we dropped
> (passing both key and iv to the alg and the mode was the most common one).
> Do you think shifting to kwargs really makes that worse?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/323/files#r8516574>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084