I will fix the Javadoc issue and the space also (I don't know why I used 4
as I'm a 2space fan and I through Golo was using 4)

Jeff


On Fri, Dec 13, 2013 at 1:19 PM, Julien Ponge <notifications@github.com>wrote:

> In
> src/main/java/fr/insalyon/citi/golo/compiler/parser/GoloOffsetParser.java:
>
> > +  }
> > +
> > +  /**
> > +   * @param stream
> > +   */
> > +  public GoloOffsetParser(InputStream stream) {
> > +      super(stream);
> > +      hookInputs();
> > +  }
> > +
> > +  /**
> > +   * @param stream
> > +   * @param encoding
> > +   */
> > +  public GoloOffsetParser(InputStream stream, String encoding) {
> > +      super(stream, encoding);
>
> Your new files seem to have 4 spaces, we stick to 2 in Golo.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/golo-lang/golo-lang/pull/118/files#r8330667>
> .
>



-- 
Jeff MAURY


"Legacy code" often differs from its suggested alternative by actually
working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury