(maint) Adds vcloud pooling to the win*all beaker node definitions

Closes PR #2100
Merge branch 'maint/stable/use_vcloud_pooling_api' into stable

* maint/stable/use_vcloud_pooling_api:
  (maint) Adds vcloud pooling to the win*all beaker node definitions
(#18931) Deprecate instead of remove original windows behavior

The original windows behavior was to attempt to translate posix mode to
the windows file.  Although we want deprecate this behavior, this
previous work on #18931 was removing it entirely.

This patch returns original behavior and marks it as deprecated for
future removal.
(#18931) Only issue deprecation when owner/group/mode not specified

This updates the current behavior to only issue the deprecation message if
 owner, group, or mode is unspecified. When all three are specified, it should
 not issue the deprecation as it shouldn't be copying remote permissions.

Without this the deprecation message would come up when someone has specified
 group/owner/mode and would not be subject to copying remote source
 permissions, thus not subject to the message itself.
(#18931) Clarify deprecation warning for source file perms to windows

Specify a little more clearly that for Window's agents we are
deprecating the copying of permissions set on the source file on the
puppet master.  This is as opposed to mode, owner, group settings on the
File resource itself.
Merge branch 'issue/18931/return-existing-windows-behavior'
Maint: Change "inactive" to "stopped" in reinventory action's description

"Inactive" is ambiguous, and could describe a stopped master, a master which
is running but happens to be idle, a master which has no agents attempting to
reach it, a master which has been removed from the load balancer, or any number
of other things. Instead, we should use the unambiguous term "stopped."
Handle malformed CSR attributes and extension requests

When a CSR custom attribute or extension request was passed to a CSR for
inclusion, the resulting error would be raised up from the openssl error
and would not be handled by anything, resulting in error messages like
'first num too long'. Since this is all but useless from the perspective
of a user, this commit adds handling to CSR creation. Errors will be
wrapped to indicate which OID was causing the failure.
(maint) Reset hiera in test_helper to avoid order issues in specs

Andrew Parker ran into spec order issues when merging into pe-puppet
which came down to the hiera instance needing to be reset in the
test_helper.  We are back-porting these changes into puppet so that we
are insulated from the same issues and to keep parity.

pe-puppet/3.2.x: 5ba1392 and 14b36ef
Merge branch 'maint/master/reset-hiera-in-test-helper'

* maint/master/reset-hiera-in-test-helper:
  (maint) Reset hiera in test_helper to avoid order issues in specs
Merge pull request #2105 from adrienthebo/maint/handle-malformed-csr-attributes

Handle malformed CSR attributes and extension requests
(#23177) Specifies default value for package type's ensure attribute

This patch makes clear that the ensure attribute for packages defaults to 'installed'.
This will prevent confusion from users and make the documentaion more awesomeer.
Merge pull request #2076 from llowder/fix_for_23177

(#23177) Specifies default value for package type's ensure attribute
Merge remote-tracking branch 'upstream/stable'
Maint: Adjust formatting of "priority" setting description

The \n" + ..." trick isn't really necessary, since we can strip whitespace and
handle first-line underhang.
(maint) Adds vcloud pooling to the remaining windows beaker node definitions
(#18931) File source_permissions setting applies to local files

The new source_permissions setting was original excluded from effecting
files with a local source (where the file is a path on the agent).  This
leaves a problem on Windows, because attempting to copy mode, even from
a local file, still produces insufficient acls.  This patch allows
source_permissions to affect local files, so that mode can be ignored,
and deprecation warnings appear.  We also added a debug message to the
resource to make it possible to pinpoint which File resources are using
this deprecated method.
Merge remote-tracking branch 'jpartlow/issue/18931/source_permissions_apply_to_local'

* jpartlow/issue/18931/source_permissions_apply_to_local:
  (#18931) File source_permissions setting applies to local files
Use the pooling api by default
Merge pull request #2106 from nfagerlund/priority_formatting

Maint: Adjust formatting of "priority" setting description