OK, but what about equals method? The table alias must be taken into the
account, right? On the other hand, shouldn't equals and hasCode methods be
in sync? If tve1.equals(tve2) then tve1.hashCode() == tve2.hashCode() and
vise versa?


On Mon, Oct 14, 2013 at 11:34 AM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/expressions/TupleValueExpression.java:
>
> > @@ -180,6 +261,9 @@ public int hashCode() {
> >          if (m_tableName != null) {
> >              result += m_tableName.hashCode();
> >          }
> > +        if (m_tableAlias != null) {
> > +            result += m_tableAlias.hashCode();
> > +        }
>
> Do not use m_tableAlias in the hash code -- it is not ALWAYS required for
> equality.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/5/files#r6946564>
> .
>