working on view and started generic controller