removed string generation from controller