Converting the signal generator to be a more holistic trade generator
note
rename