update generic params