19694 - Remove plugin.discovery.timeout

Remove another example from the docs that reference this option we've
removed
17930 - mcollective: direct addressing mode when using reply queue

The fire_and_forget mode of requests were not made direct_request
aware while adding the direct addressing communiations mode.

The result of this was that setting :process_results => false and
doing direct requests would result in the request always being broadcast
and not sent out only to the nodes supplied via the discovery layer

This addresses that and adds tests around this method
17930 - mcollective: direct addressing mode when using reply queue

Also handle the case where a discoverer forces direct mode but no
discovery has been done yet
17930 - mcollective: direct addressing mode when using reply queue

And handle the case where the 'mc' discovery method is used and specific
node information is supplied that is not a regex
20282 - Puppet agent; nodes file with spaces

Identities can only match /^[\w\.\-]+$/ which is enforced in the config
class.

The flatfile discovery method exist so that someone can put a bunch of
identities in a file and use that for discovery, thus the identities
have to adhere to the same rules but this check was never done which in
some circumstances could result in incorrect 'No responses from' errors
etc.

This commit enforces the same check when reading flatfiles resulting in
an error to the user when they have an error in their file
20388 - Mcollective should have sane defaults for configfiles on windows

This commit adds sane defaults for the server.cfg and client.cfg files.
The other configuration files can then be specified in those two files.
As these merely add defaults, any commandline flags for configfile
location will override the default.
20388 - Mcollective should have sane defaults for configfiles on windows

changelog
20059 - Data matcher logs bad errors when query returns nil

In the past when a data query field did not get assigned a value it
will default to nil which would log an non descriptive error when it gets
compared.

Data query fields that default to nil will now immediately return false,
meaning that all unset query values will evaluate to false.
20059 - Data matcher logs bad errors when query returns nil

changelog update
maint: Update a few orphaned links to marionette-collective.org

These links still live but the site's folded into puppetlabs.com
so they were 404. This commit updates the text to point at the distro-specific
dependencies repo and changes the DepRPMs link anchor to point at
yum.puppetlabs.com.
maint: update testing for windows

Add some special handling and exclusions for windows based machines
maint: improve new line detection so tests pass on windows and unix