[ticket/11314] Cleanup core.js coding

function errorHandler() was used in returnHandler() before it was defined.
The unused variable alert has been removed from errorHandler(). Overuse of
the var keyword for the variable sign has been removed and the if
statement has been simplified. The definition of the variable i has been
moved outside of the for loop definition. The var keyword shouldn't be
used inside the definition of the for loop.

PHPBB3-11314
[ticket/11314] Add missing semi-colons

Omitting the semi-colon is not legal behavior for JavaScript.

PHPBB3-11314
[ticket/11314] Use return variable instead of overusing the return keyword

Use a return variable and modify it to our needs.

PHPBB3-11314
[ticket/11314] Add missing "use strict" to timezone.js files

PHPBB3-11314
[ticket/11314] Fix whitespace issues

PHPBB3-11314
[ticket/11314] Add missing radix parameters

PHPBB3-11314
Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11314
[ticket/11422] Increment assets when database_update is complete

PHPBB3-11422
[ticket/11106] Undefined index EDITED_TIME_TOTAL notice.

When viewing a private message, when message edit count is 1
Undefined index EDITED_TIME_TOTAL php notice appears. Changed
the message formatting method to what is used in viewtopic.php.

PHPBB3-11106
[ticket/11362] Correctly sanitise the directory path

We need to correctly remove ../ form the path if possible by removing the
previous folder aswell. Otherwise the finder is unable to locate /adm/style
directories in extensions as he is looking for /adm/../adm/style instead.

PHPBB3-11362
[ticket/11362] Add unit test for ../ in directory paths

PHPBB3-11362
[ticket/11440] Remove useless/incorrect comment.

PHPBB3-11440
[ticket/11440] Cast values of the $user_ids array to integer before sql_in_set.

PHPBB3-11440
[ticket/11334] Properly generate controller URL until paths issue gets fixed

PHPBB3-11334
[ticket/11334] Add a test for the controller helper URL method

PHPBB3-11334
[ticket/11334] Make url helper method public

PHPBB3-11334
[ticket/11334] Make $phpbb_dispatcher global, as done in append_sid test

PHPBB3-11334
[ticket/11334] Remove extraneous period

PHPBB3-11334
[ticket/11334] Include functions.php and fix class name in tests

PHPBB3-11334
[ticket/11334] Expand functionality of helper->url()

Expanded the functionality of helper->url() to support all parameters of
append_sid() itself.

PHPBB3-11334