@behackett ++ agreeeeeed
On Aug 8, 2013 7:03 PM, "Brandon Black" <notifications@github.com> wrote:

> In lib/mongo/pool/socket/base.rb:
>
> > +        # @return [Object] The data read from the socket.
> > +        def read(length)
> > +          alive!
> > +          handle_socket_error { @socket.read(length) }
> > +        end
> > +
> > +        # Writes data to the socket instance.
> > +        #
> > +        # @example
> > +        #   socket.write(data)
> > +        #
> > +        # @param  *args [Object] The data to be written.
> > +        #
> > +        # @return [Integer] The length of bytes written to the socket.
> > +        def write(*args)
> > +          alive!
>
> Definitely a mistake.
>
> However, after talking with @behackett <https://github.com/behackett> a
> bit more about this earlier today, I'm actually going to get rid of alive?and
> alive? all together and just rely on handle_socket_error to deal with
> this. He's convinced me that there's little value in doing that check up
> front vs just attempting the read/write and handling it if it doesn't work
> out.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mongodb/mongo-ruby-driver/pull/241/files#r5672611>
> .
>