This will be done during the actual code cleanup - review. I only focused
on the struct in headers refactoring. I didn't want to touch the internal
part yet as it make more sens to do that together.



On 14 August 2013 14:12, Aidan Shribman <notifications@github.com> wrote:

> In drivers/heca/base.c:
>
> >  {
> > -        struct dsm_module_state *dsm_state = get_dsm_module_state();
> > -        struct dsm *dsm;
> > -        struct dsm **dsmp;
> > +        struct heca_module_state *dsm_state = get_dsm_module_state();
> > +        struct heca_space *dsm;
> > +        struct heca_space **dsmp;
>
> Better to write
> struct heca_space *dsm, **dsmp;
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hecatonchire/linux-heca/pull/33/files#r5762760>
> .
>



-- 

Dr. Benoit Hudzia

M +44 (0)79 834 46729
<benoit.hudzia@sap.com>

mailto:benoit.hudzia@gmail.com <benoit.hudzia@sap.com>