I dont think that platform will define true or false. (even if it does, it
is weird for a common keyword like this). And #undef might avoid some
preprocessor warnings. But in the end, I feel the old version is good
enough. Thanks.


On Sun, Nov 10, 2013 at 4:19 PM, Yichao Yu <notifications@github.com> wrote:

> In src/lib/fcitx-utils/utils.h:
>
> > @@ -75,10 +75,19 @@
> >  /**
> >   * fcitx true
> >   */
> > +#ifdef true
> > +#undef true
>
> @taylorchu <https://github.com/taylorchu> why "@" me??
> What I mean is if the macro true or false is already defined on some
> platform, why not skip the #define's below all together rather than undef
> and define them again.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/fcitx/fcitx/pull/138/files#r7550781>
> .
>