Documentation for MARC Import Remove Fields

MARC Import Remove Field documentation added to docs/admin

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
Documentation for Binary MARC21 Feeds and search enhancements

Documentation for Binary MARC21 Feeds and Bibliographic Search Enhancements added to opac/advanced_features.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
Edits to documentation

Edits to fit documentation structure.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
Search clicked /and/ preceding sf values

When looking for authority records to control a bib field, we currently
search using exactly, and only, the subfield that was clicked.  This
commit changes that so that the full field up to and including the clicked
subfield is used in the simple authority heading search we perform to find
the best-match (pivot) authority record.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Use the centralized initialization method for QP

QueryParser maintains an effective singleton for internal configuration of
the driver in order to avoid going to the database on every search request
to gather configuration parameters.  There is also a centralized sub that
has the task of properly configuring said singleton.  Previous to this commit
we were not using that centralized initializer in one case, and that case
happened to be the most important initialization of QP in all of Evergreen.
The fallout from that was that some configuration was not being gathered
and passed to QueryParser, resulting in incorrect search SQL being generated.

This is rectified by using the centralized initializer everywhere that it
is needed and can be used -- and particularly in the effected case.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Repair fine generator memory leak

Calling "next" from within a "try" block results in a memory leak,
presumably because "try" is a tangled nest of subs and evals.
Replacing the "try" with a good ol' "eval" avoids the leak.

This can be reproduced with the following:

---------
use Error qw/:try/;

foreach (0..200000) {
    try {
        next;
    } catch Error with {
    };
}
---------

This particular leak in the fine generator is onerous when the fine
generator is run often (e.g. every 15 mins), which means circs that
have already been processed for the day are re-analzyed over and over,
causing the code to continue early (next) to the next loop iteration
for large numbers of circs.  It also happens when a circs are skipped
because they have no fine interval, rate, or max fine.

You know this is happening because you will see something like this in
the storage stderr log:

Exiting eval via next at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm
line 820.

Exiting subroutine via next at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm
line 820.

This patch does not avoid the "exiting eval via next" warning, since
we're still next'ing out of the eval.  It just avoids the memory leak
(and the "Exiting subroutine" warning).  More extensive refactoring is
needed to to completely remove the second warning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Post-2.5-m1 whitespace fixup

This is an attempt at an automated whitespace cleanup for the m1
milestone of version 2.5.  It was created using the following
commands (run from Open-ILS/src/perlmods/lib):

find . -name "*.pm" \
-exec sh -c 'sed "/<</s/\t/    /g" < {} \
| expand -t 4 > {}.fixed ; \
cp --no-preserve=mode,ownership {}.fixed {}; \
rm {}.fixed' \;

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Fixes to MARC batch import docs

Added needed subheadings to the MARC batch update docs. Also shortened
line lengths and modified intro that focused on 2.2 new features.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>