Leave that has is, I'll change my cloudfront file so that it generates a
file without the string in the file.

Thank you for the help.


On Mon, Aug 26, 2013 at 2:54 PM, dpetzel <notifications@github.com> wrote:

> In recipes/server.rb:
>
> > @@ -22,8 +22,8 @@ class Chef::Recipe
> >   include ZenossHelper
> >  end
> >
> > -unless node['java']['oracle']['accept_oracle_download_terms'] == true
> > -  Chef::log.error("You have not accepted the Java License Agreement" +
> > +unless node['java']['oracle']['accept_oracle_download_terms'] == true || node['java']['oracle']['accept_oracle_download_terms'] == "true"
>
> I really don't like the idea of proliferating incorrect use of that
> attribute. As an example if someone were to (for some odd reason) set this
> value to the string "false" this line in the java cookbook would
> incorrectly process it as true
> https://github.com/opscode-cookbooks/java/blob/master/providers/ark.rb#L61
>
> That said, the chances of that happening are probably pretty slim.. Could
> you maybe insert a comment with a reference to the relevant cloudfront code
> so we are explaining why we are supporting the string variant?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ZCA/zenoss-chef-cookbook/pull/12/files#r5977952>
> .
>



-- 
Site Reliability and Web Operations engineer at http://archive.pt
https://sites.google.com/site/simaofontes/