The regex performance won't be an issue.  I'd rather it be slow and
reliable than fast and flaky :-)
On May 14, 2013 1:14 PM, "Shad Laws" <notifications@github.com> wrote:

> In modules/gallery/helpers/gallery_task.php:
>
> > @@ -398,42 +398,60 @@ static function fix($task) {
> >        switch ($state) {
> >        case self::FIX_STATE_START_MPTT:
> >          $task->set("ptr", $ptr = 1);
> > -        $task->set("stack", item::root()->id . ":L");
> > +        $task->set("stack", item::root()->id . ":album:1:L");
>
> Come to think of it, we can make it even smaller if we use regex...
> "12345L10" is easily broken apart into its three components. The only
> kicker is that it'll be a smidgeon slower... think the hit even matters
> given all the DB queries around it?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gallery/gallery3/pull/366/files#r4222326>
> .
>