r=me if you add comments


On Sat, Dec 14, 2013 at 7:56 AM, Huon Wilson <notifications@github.com>wrote:

> In src/librustc/middle/trans/debuginfo.rs:
>
> > @@ -687,6 +689,9 @@ pub fn create_function_debug_context(cx: &mut CrateContext,
> >      let arg_pats = fn_decl.inputs.map(|arg_ref| arg_ref.pat);
> >      populate_scope_map(cx, arg_pats, top_level_block, fn_metadata, &mut fn_debug_context.scope_map);
> >
> > +    // Clear the debug location so we don't assign them in the function prelude
>
> Is this the key piece that makes sure we handle the __morestack prelude
> correctly? It's probably worth expanding this comment to cover *why* we
> need to handle this specially (and at least a mention of __morestack so
> that there is no ambiguity about what "function prelude" means).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mozilla/rust/pull/10966/files#r8351606>
> .
>