Fix 0 sale price not returning true in is_on_sale 

fixes #3128