Hi,

thank you that you reviewed the code so quickly.

On Tue, Apr 02, 2013 at 08:47:05AM -0700, Nigel Taylor wrote:
>   In lib/FlashVideo/Site/Vk.pm:
>
> > +package FlashVideo::Site::Vk;
> > +
> > +use strict;
> > +use FlashVideo::Utils;
> > +
> > +sub find_video {
> > +  my ($self, $browser, $embed_url) = @_;
> > +  my $title = "";
> > +  my $host = "";
> > +  my $uid = "";
> > +  my $vtag = "";
> > +  my $url = "";
> > +  my $reget = 0;
> > +#  return unless ($embed_url !~ /^http:\/\/([^.\/]+\.)?vk\.com\/.*/);
> > +
> > +  # it seems that ampersands are often escaped (why?)
>
>   Add after line 5..
>   use HTML::Entities; or use HTML::Entities qw(decode_entities);
>   .....
>
>   $new_url = decode_entries($embed_url);
>   ....

Ah, right, I'll do, thanks
>   ....
>   Not sure why you would need to do this, need examples of why it's needed.
>   Or reget the page.

It seems to be mere obfuscation for this web, but I may be wrong. It
is correct, that frame URL doesn't need decoding always. Maybe I
should create some different provider as "metaprovider" here? I'd be
glad if you could propose some clean way here. Unfortunatelly (for us)
serialycz.cz provides various embedded frames from various provider.

Page which needs that http://www.serialycz.cz/2010/04/v-01x01/
page, which does not http://playserial.eu/index.php?id=349&serial=4400
(first entry)

>> +  $url = $host . "u" . $uid . "/videos/" . $vtag . ".360.mp4";
>> +  debug ("URL: '" . $url . "'");
>> +  return $url, title_to_filename($title);

>Your url ends in .mp4, so download should be mp4 not default flv,
>should be using return $url, title_to_filename($title, "mp4");

Right, will do.

>Need example to check, site could be missleading and .mp4 url does
>download flv content.

$ file -k /data/Video/v-2009-1x01.mp4
/data/Video/v-2009-1x01.mp4: ISO Media, MPEG v4 system, version 1

It seems to be really MP4 file.

>To give the site plugin it's own version number I will add this.
>
>our $VERSION = '0.01';
>sub Version() {$VERSION;}
>
>Any changes in future the version is incremented.

Will add this too.

Thank you.

Best regards,

Tomas Cech
Sleep_Walker