Okay. I'll change to use isinstance. If we want to allow old styles
classes, would want:

isinstance(object, (type, types.ClassType))
On Nov 10, 2013 2:38 PM, "Alex Rothberg" <agrothberg@gmail.com> wrote:

> Do you mean instead of " type(flavor) is type“ or instead of the entire
> predicate?
>
> If the former, I suppose. I'm not sure what subclassing type entails.
> On Nov 10, 2013 2:20 PM, "Phillip Cloud" <notifications@github.com> wrote:
>
>> In pandas/io/html.py:
>>
>> > @@ -665,10 +682,14 @@ def _print_as_set(s):
>> >  def _validate_flavor(flavor):
>> >      if flavor is None:
>> >          flavor = 'lxml', 'bs4'
>> > -    elif isinstance(flavor, string_types):
>> > +    elif (isinstance(flavor, string_types))\
>> > +        or (type(flavor) is type and Flavor in flavor.__bases__):
>>
>> Can't you just do isinstance(flavor, type) here?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/pydata/pandas/pull/5395/files#r7549704>
>> .
>>
>