Hi james, thanks for the comments

I have looked into this change.
PColumns need to have a position wich means I need to know the table and it's previous columns to insert the dynamic one at the end. If I do this in visit  my feel is that i do the job twice since in createTableRef I'll need to find the table to create the ref. So would'nt it be better to the send a list of ColumnDef and in the createtableRef turn them into PColumn, at such time I have the table and the metadata client.

Currently SelectFromClauseVisior uses the FromClauseVisitor  visit function, If I were to create one for SelectFromClauseVisitor  I would have to change from private to protected the folowing entries.
private final ListMultimap<Key, TableRef> tableMap;
private final List<TableRef> tables;
I would also need to use metadataclient.getLatestTable and switch that from private to protected.

Maybe I'm missing something.

Sorry to bother you with such small details, I definitly want to do the best possible jod in this feature request.

thanks