started integrating valueset concept