do we need add params for vectors ?