wip. need to attr serialisation