Not really.  The print statement let me see the directly error in MATLAB but there is not much value in that for normal users, so I’m good with your change.

-Mark

From: Tom Aldcroft [mailto:notifications@github.com]
Sent: Tuesday, March 26, 2013 11:56 AM
To: sot/eng_archive
Cc: Mark Baski
Subject: Re: [eng_archive] Initial remote access implementation from M Baski (#50)


In Ska/engarchive/fetch.py:

> +            if remote_access.access_remotely:

> +                # If accessing a remote archive, establish the connection (if

> +                # necessary)

> +                if not remote_access.connection_is_established():

> +                    try:

> +                        if not remote_access.establish_connection():

> +                            raise remote_access.RemoteConnectionError \

> +                                ("Unable to establish connection for remote fetch.")

> +                    except EOFError:

> +                        # An EOF error can be raised if the python interpreter is being

> +                        # called in such a way that input cannot be received from the

> +                        # user (e.g. when the python interpreter is called from MATLAB)

> +                        # If that is the case (and remote access is enabled), then

> +                        # raise an import error

> +                        print "Unable to interactively get remote access info from user."

> +                        raise ImportError

Was there a reason to not do raise ImportError("Unable to interactively...")?

—
Reply to this email directly or view it on GitHub<https://github.com/sot/eng_archive/pull/50/files#r3533610>.