On 08/20/2013 05:41 PM, chrisdearman wrote:
>
> In drivers/misc/jz_dmmu/dmmu_jz4780.c:
>
> > @@ -210,6 +210,10 @@ static int fill_tlb_address(void *page_base, struct dmmu_mem_info *mem,
> >  	mem->end_offset = ((unsigned int)mem->vaddr + mem->size) - (unsigned int)end;
> >  
> >  	s_pos = tlb_pos;
> > +
> > +    if (page_num <= 0) {
> > +        return(-EINVAL);
> > +    }
>
> Piet, could you fix the indentation, remove the {} around the return
> statement and the () around the return value to conform with the rest
> of the file?
>
Sure.

The Google coding style encourages the use of brackets on single line
blocks.
Steve Jobs and the Nexus community also encouraged it as I recall.
Unfortunately this is kernel code, and I think Linus leans toward no
brackets.

-piet

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/IngenicSemiconductor/KERNEL-NPM801/pull/1/files#r5885261>.
>