It only moves if people review it.

R

On Dec 4, 2013, at 5:10 AM, Chris Ricker <notifications@github.com<mailto:notifications@github.com>>
 wrote:


In install-scripts/install.sh:

> @@ -107,8 +149,7 @@ export FACTER_build_server_domain_name=${domain}
>  export FACTER_build_server_ip=${build_server_ip}
>  export FACTER_puppet_run_mode="${puppet_run_mode:-agent}"
>
> -#puppet apply manifests/setup.pp --modulepath modules --certname setup_cert
> -puppet apply manifests/setup.pp --modulepath modules --certname `hostname -f`
> +puppet apply /etc/puppet/manifests/setup.pp --modulepath modules --certname `hostname -f`


Sure, but

  *   that review isn't moving and we have < 2 weeks to release
  *   I don't see the community being enthusiastic about this level of Cisco-ness being done upstream. Seems a little too far on the company side of company vs community

—
Reply to this email directly or view it on GitHub<https://github.com/CiscoSystems/puppet_openstack_builder/pull/1/files#r8093939>.