[BUGFIX] Width of action column is wrong

The width of the action column in the workspaces module is
wrong. 5 icons with a width of 16px each need to be displayed
and results in a required width of 80px.

Fixes: #50210
Releases: 6.0, 6.1, 6.2
Change-Id: I3e1cbfd9be53c57dad86a6003edbf38b559dab73
Reviewed-on: https://review.typo3.org/22434
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[TASK] Improve logout button styling and add id

Change-Id: I093d38bb048e96257a35931dbd3f36f85796e26c
Resolves: #50227
Releases: 6.2
Reviewed-on: https://review.typo3.org/22452
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[TASK] phpdoc: Use boolean/integer instead of bool/int

Change-Id: I44d65aa2669e4516cfb2edb26d937ef70a58df2d
Resolves: #50253
Releases: 6.2
Reviewed-on: https://review.typo3.org/22470
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Two mailforms on a page cause error on field validation

Check formname for uniqueness and if need append a unique hash.

Change-Id: Ifd33c5130c383f3afc3e5e6d80c1be017f25ec5b
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Fixes: #16114
Reviewed-on: https://review.typo3.org/12844
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[TASK] Make DiffUtility faster and much more scaleable.

The method DiffUtility->explodeStringIntoWords() calls array_merge()
inside a loop. The cost of constantly doing a function invocation and
merging arrays needlessly slows the method and the whole diff utility.
Moving the array merging outside the loop, the method becomes faster
and able to handle much larger input.

Change-Id: I4c2d21cff9b18392e89e316fec9dc615e715a073
Resolves: #50318
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22508
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[TASK] Remove comments for revised in TYPO3 3.6

Double class comments are also removed.

Change-Id: Ic46d7e353b8874e46ae720a2e3603bf54cc8d524
Resolves: #50409
Releases: 6.2
Reviewed-on: https://review.typo3.org/22543
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Revert "[BUGFIX] Links on external pages don't get indexed"

This reverts commit 819b5be0ac81004371fee2f0e6386cc32233a59b

Discussion with Mario Rimann and Stefan Neufeind leads to the conclusion
that this patch breaks current behaviour and that it's not possible to
implement both use cases without an extra setting. Agreement was to
revert this change and turn the bug report into a feature request.

Change-Id: Iebb62c89959328cc460fea5f1f46fb824b892822
Reviewed-on: https://review.typo3.org/22552
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
[TASK] Revise typo3/sysext/README.txt

* Replace GIT repository link with the new one
* Remove information about submodules

Change-Id: I60db762ce831c7edea413d9f7780a5617b7f9e96
Resolves: #50410
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22544
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] require_once of vfsStream triggers travis fail

vfsStream is now included in ext:phpunit, the pear module is
not maintained and was removed in travis.
This triggeres a failure in the phplint check. All require_once
calls are removed for now, ext:phpunit now also provides an
autoloader for vfsSstream.

Change-Id: If1b07c31e999111e6b5d2804a9f5cc457066b7b0
Resolves: #50442
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22566
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] rsaauth BackendFactory does not unset backend

The BackendFactory of rsaauth tries to forcefully unset an
instantiated backend, but unsets the class name instead of the object.

Resolves: #50411
Releases: 6.2, 6.1, 6.0
Change-Id: I26712c73b74788cad159f95c7e54cbbbf69e8764
Reviewed-on: https://review.typo3.org/22545
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[BUGFIX] Improve method annotation and type hinting in FAL

Add a missing "@throws" annotation and a namespaced comment.

Change-Id: Ibc929a01dbfdef9cf8730a8da259570786b6118c
Resolves: #50447
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22572
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Test regression from patch for #47192

This fixes a unit test regression introduced with the solution for
 #47192.

Change-Id: I0e70b916f24fada7f76e7fd835d31e54ca41a402
Related: #47192
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22461
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[BUGFIX] Uninstall extension with dependency throws Exception

Exception is thrown if uninstalling an extension with
dependecies on that extension. Catch the exception and
show a nice Flashmessage.

Change-Id: I434a4e1e1d83f43a6f5d4c99a82433e35ddd92f9
Resolves: #49722
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22162
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[BUGFIX] Fix failing test

The test failes due to incorrect mocking, what leads to not claimed
properties for the test.
Additionally the expected call amounts where handled more strictly
where fitting.

Releases: 6.2, 6.1, 6.0
Resolves: #50458
Change-Id: I34214fb9ef9e9935892aa03518505b877538e128
Reviewed-on: https://review.typo3.org/22584
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[TASK] Use real boolean value for trimExplode third param

Make use of boolean value TRUE as third parameter in
trimExplode function.

Change-Id: Ied33efac6cddfc2e2798435fe9b1ef748c11905b
Resolves: #50402
Releases: 6.2
Reviewed-on: https://review.typo3.org/22542
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[TASK] Use real boolean value for getLL second param

Make use of boolean value TRUE as second parameter in
getLL function.

Change-Id: I15fe034159e4bb8ecb7c15f8f6e915975fca7c9b
Resolves: #50393
Releases: 6.2
Reviewed-on: https://review.typo3.org/22538
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[BUGFIX] FAL does not copy subfolders cleanly

If full structures with sub folders are copied around in FAL
local driver, sub folders are not correctly created in the
target directory.

This is detected in unit tests after recent vfsStream updates in
ext:phpunit.

The patch adds a flag to the Iterator code to also include
directories to fix the issue.

Additionally, the existing two unit tests also tested multiple other
methods of the local driver and are functional tests. The patch moves
those two tests to the functional section and adds three simple unit
tests with correct mocking instead.

Change-Id: I30d3c8bd5c6538b3fe23405d97bcddff6c1ff405
Releases: 6.2, 6.1, 6.0
Resolves: #50472
Reviewed-on: https://review.typo3.org/22596
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] FAL wrong \RecursiveIteratorIterator usage

If using \RecursiveIteratorIterator on \RecursiveDirectoryIterator,
flag SELF_FIRST must be used, otherwise only leaves (files) and not
also directories are returned. This behavior is a bit dependent on
the PHP version used, younger versions (> 5.3.3 seem to do it
correctly).

Furthermore, in copyFolderWithinStorage() $itemSubPath contains
the "relative" path part and not only the node name, checking
equality to "." or ".." fails then if handling sub directories.
So, directories may be created multiple times, resulting in mkdir()
warnings. This is fixed by getting the node name itself and using
that for comparison.

Resolves: #50476
Releases: 6.2, 6.1, 6.0

Change-Id: Ifac4b28f4e02ec8a9bf5891739cf66c1e1074af9
Reviewed-on: https://review.typo3.org/22602
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Failures in em unit tests due to phpunit update

Young phpunit versions seem to handle clones a bit differently,
resulting in test failures in extension manager tests. The tests
are adapted a bit to fix this.

Change-Id: If70561743f68a62167e41ee4c23ae96b56f83ab9
Resolves: #50478
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22604
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[TASK] Remove empty .gitmodules file

With removal of git submodules the .gitmodules file is empty
and can be removed now.

Change-Id: I453f63c0852825b46e9ea62f87385d9eace25134
Resolves: #50480
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22613
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn