I see the issue. I suppose you've hit upon the best solution, then.

Welll ….. if the class as a whole represents a list of ResolvedEndpoints,
then maybe this method is really the #to_a of the object.

Cheers,
    Tony


On Thu, Oct 17, 2013 at 4:49 PM, Brian Szmyd <notifications@github.com>wrote:

> In lib/right_support/net/dns.rb:
>
> > +  end
> > +
> > +  # An AddressList represents the resolution of a host which can contain
> > +  # multiple IP addresses or entire IP address ranges of varying size.
> > +  class AddressList
> > +    attr_accessor :uri
> > +
> > +    def initialize(ips)
> > +      @ip_addresses = []
> > +
> > +      ips.to_a.each do |address|
> > +        @ip_addresses << IPNet.new(address)
> > +      end
> > +    end
> > +
> > +    def addresses()
>
> I totally agree with the statement about it not being addresses. However,
> the original resolve code returned both addresses AND uris depending on
> what you gave it, so I had to maintain the same contract here or else
> change the interface and all the callers, which I don't think there are a
> ton of...but still.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rightscale/right_support/pull/100/files#r7051237>
> .
>