Yes, that's right


On Fri, Oct 11, 2013 at 7:48 PM, Eli Levine <notifications@github.com>wrote:

> In src/main/java/com/salesforce/phoenix/compile/WhereCompiler.java:
>
> >          WhereExpressionCompiler whereCompiler = new WhereExpressionCompiler(context);
> > -        Expression expression = where.accept(whereCompiler);
> > +        ParseNode where = statement.getWhere();
> > +        Expression expression = where == null ? TRUE_EXPRESSION : where.accept(whereCompiler);
>
> @jtaylor-sfdc <https://github.com/jtaylor-sfdc>, can you check this? I am
> assuming a TRUE_EXPRESSION is equivalent to a null where expression. Is
> this OK to do?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/forcedotcom/phoenix/pull/453/files#r6930405>
> .
>