Make the exception string a little more useful

This partial helps bug #1119883

Change-Id: I247ab39406bcc608c0d66a8140dc198b93491ac1
heat tools : openstack script install mysql via openstack-db

Don't install mysql-server in tools/openstack, instead allow
openstack-db to non-interactively install it for us, which means
the root password is set as per the -r password option when
installing on a fresh system with no mysql

NOTE : if testing this on a system which has had mysql installed,
do yum remove mysql-server && rm -fr /var/lib/mysql or the
reinstalled mysql will use the old credentials

fixes bug 1133502

Change-Id: Ie3ba56e5f971e032be4f099e81cbb24afe76dfbc
heat clients : make boto client library pass disable_rollback

Make the boto_client.py wrapper correctly interpret the DisableRollback
argument, so the --disable-rollback option of heat-boto will work

fixes bug 1131283

Change-Id: If31daa1583ff836fbb3f67799b89602b16f904e3
heat engine : fix hardcoded DisableRollback value

Engine API should return the real state of rollback now we
implement it, not hard-code to True

fixes bug 1135963

Change-Id: I6b9e6ea9587fe0c84b57f34bf69c2dcec5d5c09f
Merge "heat engine : fix hardcoded DisableRollback value"
Merge "heat clients : make boto client library pass disable_rollback"
Update infrastructure to more closely match other OpenStack projects

This patch imports nova's HACKING.rst guidelines altered for Heat.
This patch imports nova's run_pep8.sh with some minor alterations.
This patch imports nova's hacking.py extensions to pep8.

This patch places the run_pep8 logic in a separate file rather than
having it spread between tox.ini and run_tests.sh.  The HACKING.rst
requirements as well as general pep8 requirements are then enforced
with run_pep8.sh.

Avoid running once the N802 rule until dependency changelogs are
less then 50 characters.

Change-Id: If46c14668eae3cf11b8fbff46d766cc589d701aa
Fixes: Bug #1131275
Add heat-watch to pep8 checks

heat-watch was missing from pep8 checks in the past.  Tidy up heat-watch
and add to run_pep8.sh.

Change-Id: I36680b24ee90a5daeb7f8d7418b665a215026325
Fixes: Bug #1131275
Remove unused imports from repo in preperation for pyflakes

Lots of unused imports

Fixes: Bug #1131275

Change-Id: Iacb1d02173b0ec0e0dc81aff84ca6e29e60e2934
Signed-off-by: Steven Dake <sdake@redhat.com>
Gate on certain pyflakes failures

To prevent recent gating problems from typos, an
import not used and redefinition of function problems in
the source code have become gating.

Fixes: Bug #1131275
Change-Id: I7011f3ac5940afc70c38758e67a2222a66e625c3
Signed-off-by: Steven Dake <sdake@redhat.com>
Merge "Make the exception string a little more useful"
Do a metadata refresh after an explicit metadata write.

if we have a template with (logically) the following:
instance2:
   metadata
     GetAtt waitcond.data

waitcond:

when the waitcond is fired, it updates the metadata but it needs a call
to update the references in "instance2's" metadata.

bug #1135229
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Change-Id: I1a6af9112ba100b17075063f59165b448d6a11f4
Allow heat to be used without a KeyName set.

This patch lets you start an instance without setting the KeyName, which
I gather is allowed in ec2 as well.

This revision adds a template and test.

Fixes: bug #1129394
Change-Id: I667f373b73479caa506ee49d8d1615ff4aad47ed
Signed-off-by: Ian Main <imain@redhat.com>
Merge "Allow heat to be used without a KeyName set."
Fix flaky unit test

This was failing intermittently during the gate tests because there was no
dependency in the template for the Instance on the WaitConditionHandle, nor
for the WaitCondition on the Instance, so the order in which resources
would be created was somewhat random.

This patch fixes the test template, and tests updating the metadata should
occur *during* creation of the stack, as well after, to replicate a real
wait condition (which won't finish creation until the metadata update
occurs).

Change-Id: I26b5590a9ee90d205bd9f2e31bcb74e68065ac25
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Fix unit tests for Instance IP

Don't try to test the IP addresses after the instance has been deleted.

Ref bug #1091497

Change-Id: I566c26a4707edc9d210bd422dcff8fbbcc2236d5
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Split resource create into create and check_active

Change-Id: Ib8206f204e8805936defaa3431ecdf34b161e724
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Move instance polling into handle_check_active()

Don't poll for the instance status in handle_create(). Allow
Resource.create() to poll the resource using handle_check_active().

Change-Id: I13a8fefcef6594d014e7e5a3131f9342521e367d
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Refactor autoscaling adjust method

Internal uses of adjust() have slightly different needs.

Change-Id: Ibb85425f08b7b2d78be2d9ef5c8a9f464b7eead1
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Create autoscaling instances in parallel

Fixes bug #1136148

Change-Id: I02ea52df85c4ed7f0f16abcfd1ab24b35168a787
Signed-off-by: Zane Bitter <zbitter@redhat.com>