update rspec
stub! is deprecated and will be removed in 3.x, replace with stub
mock and stub are deprecated for declaring test doubles, use double directly
remove unused local variables
remove warning about == being ambiguous
remove uninitialised variable warnings
a UnknownStrategySpecified is not a LoadError, so this is superfluous and it removes deprecation warning
refactor spec to correctly not reference subject in its matchers
fix bug exposed by removing not_to raise_error by ensuring this is always an array
Merge pull request #240 from JonRowe/upgrade_rspec

Upgrade RSpec to latest version, fix deprecations, warnings