On Fri, Oct 11, 2013 at 9:58 PM, Rob Hirschfeld <notifications@github.com>wrote:

> In crowbar_framework/app/models/run.rb:
>
> >      end
> >    end
> >
> >    def self.empty?
> >      cleanup
> > -    Run.all.count == 0
> > +    Run.transaction do
>
> this is a very nice ruby way to do the loop - it needs a comment since it
> may not be obvious to readers.
>
 It is not a loop at all. :)

> —
> Reply to this email directly or view it on GitHub<https://github.com/crowbar/barclamp-crowbar/pull/732/files#r6930430>
> .
>