Hello,
I am not sure what you mean here. There is a using namespace std up in the file. Do you want it explicit in front of abs ?
N.
______________________________________

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: slava77 <notifications@github.com<mailto:notifications@github.com>>
Reply-To: cms-sw/cmssw <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Mon, 28 Oct 2013 14:17:03 -0700
To: cms-sw/cmssw <cmssw@noreply.github.com<mailto:cmssw@noreply.github.com>>
Cc: Nancy Marinelli <nancy.marinelli@cern.ch<mailto:nancy.marinelli@cern.ch>>
Subject: Re: [cmssw] PF-Based Isolation for GED Electrons/Photons (#1174)


In RecoEgamma/PhotonIdentification/src/PFPhotonIsolationCalculator.cc:

> +      if(pfIsoCand->mva_nothing_gamma() > 0.99) {
> +        if(pfIsoCand->superClusterRef().isNonnull() && refSC.isNonnull()) {
> +         if(pfIsoCand->superClusterRef() == refSC)
> +         return -999.;
> +        }
> +      }
> +  }
> +
> +  if(pivotInBarrel){
> +    if(bDeltaRVetoBarrel_){
> +      if(fDeltaR < fDeltaRVetoBarrelPhotons_)
> +        return -999.;
> +    }
> +
> +    if(bRectangleVetoBarrel_){
> +      if(abs(fDeltaEta) < fRectangleDeltaEtaVetoBarrelPhotons_ && abs(fDeltaPhi) < fRectangleDeltaPhiVetoBarrelPhotons_ ){


std::abs could be more obviously correct

—
Reply to this email directly or view it on GitHub<https://github.com/cms-sw/cmssw/pull/1174/files#r7263820>.