note issue with default values
add some tests