Made the title bar captions more descriptive

The title bar cations are no all prepended with the workspace name.

They are also no longer truncated to the first hyphen. If there was a reason for that please tell me, but i couldn't see any reason why they were, especailly as the logs use underscores as spaces which are then converted to hyphens (for a reason that is explained in a comment) so it previously meant that multi-worded log names were truncated.

To Tester:

Make sure that the title bar captions show the workspace name, log name and a number which should be a fallback inidivitual identifier.

Be aware that this ticket was done while #7968 was awaiting merging into master thus the bug fixed there reared its head; it should only cause debug assertions on windows but this should be kept in mind.

Refs #8031
workspace name underscores are no longer converted

I found that the caption settign method was converting hyphens to underscores as well as the QString::replace that was already in there.

There was a comment note that underscores may cause problems for the legendwidget, so that may need looking at

Refs #8031
Removed commetned out code

Karl mentioned some leftover commented code, it's now been removed

Refs #8031
Merge remote-tracking branch 'origin/master'

into feature/8031_workspace_in_sample_log_name

Conflicts:
	Code/Mantid/MantidPlot/src/Mantid/MantidUI.cpp

Refs #8031
Correcting indent to stop it complaining on a push to develop

Still correcting merge confilct, this is more preventative as i just resolved this conflict between my branch and develop, on develop.

The problem still exisited here so jsut fixing it now

Refs #8031
Refactored some repeated code

I introduced some repeated code, so i've condensed and refactored it into it's own method.

Refs #8031
removed some commented code

When having a quick look at the changes i'd made, i noticed a few lines of commented code, some mine, some not. I've removed them.

Refs #8031
Refs #8031 Fixing highlighted problem

I'm working on fixing teh problem Martyn hihglighted, but the fix caused another problem that I'm now trying to track down the source of.
Merge remote-tracking branch 'origin/master' into feature/8031_workspace_in_sample_log_name
Refs #8031 fixes various crashes and improves graph titles

Graph titles are now the workspace + log name rather than the secion of the log name before the first underscore.

Fixed an out of bounds check that was revealed after fixing the issure Martyn highlighted.
Refs #8031 Removeign debugging console commands

Removing some instances where i was writing to the console so i could see the QStrings i was working with.

Corrected a spelling in a similar command i haddn't added.
Refs #8031 Dealing with a rather large merge conflict

When goign to checkbuild i had a merge conflict, just used kdiff3 to help sort it out.
Merge remote-tracking branch 'origin/feature/8031_workspace_in_sample_log_name'