Fix for 2 bugs where attribs configured thru GUI were ignored, removed unused pid_directory attrib [1/1]

Bug 1:  CES-1273: The glance add/edit form allows the user to set the value of sql_idle_timeout. This attribute is defaulted to 3600 (see default.rb), but is never used in the cookbook.

In both glance-api.conf.erb and glance-registry.conf.erb, sql_idle_timeout is hardcoded to 3600, when it apparently should be set to what was configured in the GUI (node[:glance][:sql_idle_timeout]).

To test:
Create a glance proposal setting SQL Idle Timeout to some non-default value (not 3600)
Apply the glance proposal and wait for it to deploy
Log in to the system that glance was installed on, and:
    sudo -i
    grep sql_idle_timeout /etc/glance/*
Verify that sql_idle_timeout is set to the value configured in the GUI in both glance-api.conf and glance-registry.conf


Bug 2: Fixed bug where image_cache_stall_timeout configured in GUI is ignored
#154

The glance add/edit form allows you to set the value of image_cache_stall_timeout. In glance-cache.conf.erb though, it was referencing an attribute called image_cache_stall_time. This caused image_cache_stall_time to be set to nothing in the resulting glance-cache.conf file.

To test this fix, create a glance proposal setting the value of image_cache_stall_timeout to some value in the GUI, or just note the default value. Deploy glance, then on the glance node as root:

grep image_cache_stall_time /etc/glance/glance-cache.conf

Verify it is set to the value entered in the GUI.

Removed unused attribute :pid_directory from glance default.rb
#155

 chef/cookbooks/glance/attributes/default.rb        |    1 -
 .../glance/templates/default/glance-api.conf.erb   |    2 +-
 .../glance/templates/default/glance-cache.conf.erb |    2 +-
 .../templates/default/glance-registry.conf.erb     |    2 +-
 4 files changed, 3 insertions(+), 4 deletions(-)

Crowbar-Pull-ID: 45a4e447daec54f3fef22397178074a3fe860fa3

Crowbar-Release: hydrogen