Fix warnings (final part)

Avogadro builds ok with -Werror with gcc 4.7.3

Change-Id: I524764748b4acd83a48cdb6a3a611e0d51ccb389
Fix missing return value

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>

Change-Id: I8655a0c6c75f5f008898e8636f42652192e9aee6
Applied updated NWChem test files using v6.0

Contributed by Michael Banck to clarify distribution.
Files remove strongly-worded statement from non-open NWChem.

Change-Id: I6ab01e496f05a8116e73e95e0a849c89b301db83
Merge topic 'fix-missing-return-values' into master

3a4c753b Fix missing return value
Properly set PIC flag for libspglib and libtubegen

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>

Change-Id: Ibe8f103fe3a6bfe0ad7c72c6cdfe37d0c2535899
Fix warning with Clang about tautological comparison.

Original syntax suggests checking for NULL pointer followed
by a molecule-size test.

Change-Id: I5ba3227e779af64ef907f00c73ff63d2cb4cadaa
Merge topic 'warnings2' into master

b27a72d8 Fix warnings (final part)
Merge topic 'FIX_clang_tautological_warning' into master

20df2900 Fix warning with Clang about tautological comparison.
Fix crash with dipole moment visualization.

Use less accurate Gasteiger charge calculation to avoid
apparent race condition with MMFF94 charges.
Solves PR#691.

Change-Id: I57764c17bcf12c67a0deb1801d004a1f04722bcb
Merge topic 'FIX_shlib-pic-flag' into master

3adb5714 Properly set PIC flag for libspglib and libtubegen
Merge topic 'FIX_dipole_crash' into master

3907b356 Fix crash with dipole moment visualization.
We now require CMake 2.8.9 (using new features)

Commit 3adb57 introduced the use of position independent code property
that was not introduced until CMake 2.8.9. Increasing our minimum
required version inline with what we are using.

Change-Id: I04c3db2145f31f54b6de7354212bcfe39631ccbd
When loading QTAIM files, switch to the navigate tool.

Fixes PR#687.
Consistent with normal Open.. or Import.. behavior.
Also switched menu items to include "..." to indicate
they open new files, consistent with UI elsewhere.

Change-Id: I8eb0f87155748a370bd842cdfe1b049a504f343c
Allow exponents to use "D+XX" or "D-XX" number format.

Fixes PR#686 with MOLPRO Molden files.

Change-Id: Ib91d3c17449b57ce4212a4499e25bbafb17bfe97
Make QTAIM compile and work on Windows

Rewrote the math utilities for QTAIM to be simple functions in a
namespace, pass their arguments by reference and adjusted style to
be a little more consistent.

Change-Id: I11737cb521359c1e038930f054630419d2309a30
Merge topic 'ENH_qtaim-navigate-tool' into master

79b241a1 When loading QTAIM files, switch to the navigate tool.
Merge topic 'FIX_read-molpro-molden' into master

c666de6a Allow exponents to use "D+XX" or "D-XX" number format.
Fix crash when save to files with stereo perception.

Need to make sure OBMol/OBAtom objects have correct
atom IDs. Fixes PR#675 for me -- save to MDL crash.

Change-Id: Idd11b4ba0fc172e462051dcffbc1c3263c5e4901
Fix crash when manually drawing a hydrogen PR#679.

To reproduce the crash:
1) Draw something
2) Turn off adjust hydrogens and delete a hydrogen or another atom
3) Turn on adjust hydrogens again, set the element to hydrogen.
4) Draw from the atom to a new space (for the hydrogen).
5) Everything fine until mouseRelease. Crash.
Now we don't try to adjust hydrogens when drawing a hydrogen atom.

Change-Id: I4d5eaf6b596051a6c61a75e621c2693255adf8d8
Set a default and check value of the view perspective.

Should fix PR#627 and possibly others.

Change-Id: Ifd5982bbaa32cd265ba99e075154f081a4351a1d