clear up method parameters for _modify_rules

'table_name' is always used anyway, so there's no reason to have it as
optional especially as it's not perfectly clear that it's only needed
when current_lines is empty

'binary' was never used

Change-Id: I2c6bcf3fcff1c097d1f5c5ae34aa3428a94dabdc
Fixes volume attach on Hyper-V with IPv6

Fixes bug: 1148536

This patch splits the target_portal address:port pair properly in case of IPv6
addresses during login on the storage target.

Change-Id: I87c1153dd0289ac73fb35c2cd57a27d128042b2c
Check if flavor id is an empty string

Now once a flavor is created with empty string id, its id and
name cannot be specified when we use or delete the flavor.

This checks if flavorid is empty when creating a new flavor.
And if so, assigns auto-generated flavorid.

Fixes bug: 1148563

Change-Id: Ib48c4cc4ebd993d1f3f3d60a7bb856eff3c279d5
Fixes instance action exception in "evacuate" API.

'Evacuate' instance action was not created (incl. in the DB) which
caused exception to be raised during action_event_start.

Change-Id: Iec5f0a91f9b08fbdcf3ace1eaa0efbc4d9d8fc04
Fixes: bug 1152512
Add numerous fixes to test_api_samples

- Throw IOError when a template for POST/PUT operations
  does not exist instead of returning an API response error
- Create template and sample on first run when those
  don't exist. It takes two runs of this module now
  to get those files first populated.
- Fix error labels to now specify whether we are referring to
  a sample or response when comparing response results
- Call _pretty_data() only once on sample_data before this
  param is passed to _compare_results(). This change cut the
  total execution time by .5 seconds or 1%. :)
- Create response template files which content is the same as
  its response body instead of currently 0-length body.
Fixes bug 1140384

Change-Id: Ic62ae343409b2084e6a238025a86f0b7909a1b76
Revert changing to FQDN for hostnames.

5dd1553cca7f7e62eebce75e1d936fc211b239ec moved to using a FQDN for
host names. This caused bug 1151012, but Russell and I also believe
the change will break the host column on the instances table. I can't
do a plain old git revert for this change because a lot of the code
has moved after this change.

Revert to using just the hostname (no domain), and we'll revisit the
intent of 5dd1553cca7f7e62eebce75e1d936fc211b239ec separately.

Resolves bug 1151012.

Change-Id: I944f46d6eb2a6944a12833ec8de7afa2b18e66e7
Pass migration_ref when when auto-confirming

The _poll_unconfirmed_resizes() task in compute/manager calls back to
compute_api to confirm resizes. This triggers a db lookup for the
migration, which is not allowed by no-db-compute. Since we already have
the migration, pass it through to avoid the lookup.

Since this doesn't change rpcapi (and thus, RPC clients should not
know about this optional paramter), we don't need to bump the RPC
version here.

Fixes bug 1152792

Change-Id: I4bd3b0c88968ed7f64e7df0afa12e83009ee8ccf
Merge "Fixes instance action exception in "evacuate" API."
Handle vcpu counting failures gracefully

The virDomainGetVcpus() call in libvirt can fail in some cases. This
should be handled properly in nova and not cause failures in starting
up new instances.

Fixes bug 1153694

Change-Id: I8e072c53ee2bafcb50083d793ceabe5292038ab6
Merge "clear up method parameters for _modify_rules"
Merge "Check if flavor id is an empty string"
Merge "Fixes volume attach on Hyper-V with IPv6"
Merge "Revert changing to FQDN for hostnames."
Merge "Add numerous fixes to test_api_samples"
Merge "Pass migration_ref when when auto-confirming"
Merge "Handle vcpu counting failures gracefully"