Click to finish link was missing #3319

When a participant was scheduled multiple times for the same event
in PSC, Cases did not take the date of the event. This was causing
the sections menu to show duplicate activities in the UI and was
not allowing the user to "finish" the survey thinking that the
survey was a "multi-part" survey.

This commit fixes this issue and uses the Event rather than just the
event type to determine the activities.

All instrument_plan methods that use just the event type name
instead of the event should be deprecated in favor of methods
that take the Event class as a parameter, but this will need an
audit to determine where it is necessary to use the event type name
(i.e. we do not have access to the Event object).

Closes #3319
Provider recruitment disposition #3323

The provider recruitment category Event type is "Provider Recruitment"
but the disposition category was looking for "Provider-Based Recruitment"

Updated the case stmt to use the code instead of the display_text of the event type

Closes #3323
Event is a required parameter #3319

This change removes the default parameter on these methods
to ensure that the activities returned are scoped to the given event.

Also, this commit removes an unused instruments method on
InstrumentPlan (which should really be renamed to
ActivityPlan or ParticipantActivityPlan or something like that),

All callers of these methods do send the event parameter so the
nil default could have been masking callers who had a nil event.
Merge pull request #33 from NUBIC/bug_3319

Bugs 3319 and 3323