[s1897] Some small changes

* Replace Expansion related magic numbers
* Remove an unneeded double line. Thanks to Ambal for pointing
* Add additional check for DK starting zones map file

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12364] - 90e787f)
Remove another redundant InBattleGround() check

(based on commit 0055d05)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1898] fix Singleton compile error on clang

some members of Singleton were implicitly specialized in the static function
definitions, which conflicted with the initialization of said members (clang
saw it as a redefinition of the specialization)

Signed-off-by: DasBlub <DasBlub@gmail.com>

(based on commit [12365] - 772a5bb)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1899] fix clang compile error from implicit type conversion

Signed-off-by: DasBlub <DasBlub@gmail.com>

(based on commit [12366] - ce05512)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1900] fix clang compile error from call of templated member function

Signed-off-by: DasBlub <DasBlub@gmail.com>

(based on commit [12367] - 4a407cc)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1901] Cleanup battleground code

Signed-off-by: Carl Hjerpe <lillecarl@gmail.com>

(based on commit 4814020)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1902] Remove shapeshift forced object update hack

This and 8046e0e properly fixes powershifting

(based on commit 375b139)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1903] Hack TBB code for support VS2012 (and new C++ standard in fact)

This hack will need until TBB will not support VS2012 by self.
With big chance with next TBB update in repo we can safely drop this
hack.

(based on commit [12368] - 7e9e22e)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1904] Add continued integration support using Travis CI

Every push to a repository will start a new build on travis which will
make sure that CMaNGOS still builds. Currently, Travis only supports gcc
and clang on linux, Windows and OS X build test is not yet available.

Thanks to @travis-ci for their awesome software and their
sponsors for providing the infrastructure!
For the current build status of this repository, go to https://travis-ci.org/cmangos/mangos-wotlk/

(based on commit [12369] - 7349c20)
[s1905] Add support for VS2012 building.

[ci skip] for make travis happy ;)

(based on commit 3c73ecc)
(based on commit 6f97021)
(based on commit 3c9fca4)
[s1906] Use recently introduced performance timer for additional state updates

This should give a slight performance improvement without visibly disadvantage for players.
Maybe someone is willing to test 200 as default check intervall, how this scales
[ci skip] (mostly rename :P )

(based on commit [12372] - 232f3fa)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1907] Don't send Spell::CheckCast fail result for passive auras

No need to notify client when a passive aura failed to cast (like using Cat Form indoor with Feral Swiftness talent learned).

Contributor Maxxie.

(based on commit [12373] - 66d4653)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1908] Fix compiler warning about initialization order

Fix warning: '<class>::<member>' will be initialized after <class>::<member>" (Linux/GCC).

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12374] - 7f6f284)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1909] Fix some signed/unsigned integer comparison warnings

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12375] - 1ba4ddb)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1910] EventAI - Define way mobs with difficulty flags behave outside of dungeons

This allows to script mobs for both normal map and dungeon.
In such case for the normal map only the events with normal-difficulty (EFLAG_DIFFICULTY_0) are used.

(based on commit [12378] - 5b4e4d0)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1911] Fix CMake ExternalProject_Add command for ACE on UNIX systems

(based on commit [12379] - 8cfd615)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1912] Re-sync realmd code in mangos-tbc with mangos-wotlk

Only spaces changes.

Realmd sources mustbe _exactly_ same in classic/tbc/wotlk.
[s1913] Fix behavior of spell 42631

Thanks zkillertheman for pointing

Also fix https://github.com/scriptdev2/scriptdev2/issues/33

(based on commit [12381] - b4b0f4b)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1914] Looks for passive auras that need to be recast. Like talent spell Feral Swiftness (id: 17002 and ranks), once you go inside a building and then outside again.

Contributor : Ebrithil

(based on commit [12383] - e9f2099)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[s1915] Fix recently un-outcommented code to be actually working

(based on commit [12384] - 96d1f0e)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>