Every subclass I looked at has a test_mode? function, hence why I added it
to the interface.


On 28 May 2013 08:35, John Duff <notifications@github.com> wrote:

> In lib/active_fulfillment/fulfillment/service.rb:
>
> > +        raise NotImplementedError.new("Subclasses must implement")
> > +      end
> > +
> > +      def fetch_stock_levels(options = {})
> > +        raise NotImplementedError.new("
> Subclasses must implement")
> > +      end
> > +
> > +      def fetch_tracking_numbers(order_ids, options = {})
> > +        raise NotImplementedError.new("Subclasses must implement")
> > +      end
> > +
> > +      def valid_credentials?
> > +        raise NotImplementedError.new("Subclasses must implement")
> > +      end
> > +
> > +      def test_mode?
>
> Why is this part of the interface when we have a test? Method already?
> Seems unnecessary.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Shopify/active_fulfillment/pull/21/files#r4411495>
> .
>



-- 
Chris // API & Integrations Developer @ Shopify