Ali,

If I use the logger as :
logger.loglevel(String arg 0, Object arg 1) then in the case where the arg1
is a long or a string, etc it doesn't get printed at all.(even after type
casting it or converting it into a string by using toString())
That was one of the reasons I concatenated the strings. What do you suggest
on how to proceed?(whether to concatenate it as string or is there another
way of printing out the objects).

Also, for this issue 107, I am trying to insert a flowmod with fake xids
and reproduce the issue.
For this to be achieved, is there a way of using dpctl (i.e. currently I am
running nox controller and mininet along with flowvisor)
and trying to insert a flowmod using dpctl. Is this the right approach(But
I guess there are no xids which can be added with dpctl)
or should I insert some code in flowvisor which adds fake xids along with
flowmods. Please suggest.

Thanks
Sumanth




On Thu, Feb 21, 2013 at 10:56 AM, Ali Al-Shabibi
<notifications@github.com>wrote:

> In src/org/flowvisor/classifier/FVClassifier.java:
>
> > @@ -106,7 +111,7 @@ public FVClassifier(FVEventLoop loop, SocketChannel sock) {
> >  			this.msgStream = new FVMessageAsyncStream(sock, this.factory, this,
> >  					this.stats);
> >  		} catch (IOException e) {
> > -			FVLog.log(LogLevel.CRIT, this, "IOException in constructor!");
> > +			logger.error(this.getName()+"IOException in constructor!");
>
> Yes. This avoids unnecessary concatenation if that particular loglevel is
> not active.
> … <#13cff4f89aec7e3c_13cfe1d954fd089c_>
> On Feb 21, 2013, at 1:46 PM, mssumanth <notifications@github.com> wrote:
> In src/org/flowvisor/classifier/FVClassifier.java: > @@ -106,7 +111,7 @@
> public FVClassifier(FVEventLoop loop, SocketChannel sock) { >
> this.msgStream = new FVMessageAsyncStream(sock, this.factory, this, >
> this.stats); > } catch (IOException e) { > - FVLog.log(LogLevel.CRIT, this,
> "IOException in constructor!"); > +
> logger.error(this.getName()+"IOException in constructor!"); Hi Ali, I think
> I have concatenated it as strings at multiple locations. Shall I replace
> every such log as below: logger.loglevel(String arg 0 ) with
> logger.loglevel(String arg 0, Object arg 1) Thanks Sumanth … — Reply to
> this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/OPENNETWORKINGLAB/flowvisor/pull/173/files#r3104046>.
>
>