unrar: remove special metafiles handling
pathname: remove unused return values

Return value was used only by one test, rewrote test to know expected value.
selenium-server-standalone 2.35.0

Closes #21875.
cassandra 1.2.8

Closes #21873.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
tbb: succeeds with clang 500

Closes #21881.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
git-tracker 1.6.1

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
GeoGit 0.4.0

Closes #21822.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
jenkins 1.527
elasticsearch 0.90.3

Closes #21892.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Remove stray space
Add missing false
No need to map, all? takes a block
Collapse to one-liner
Reverse conditional
Return value of modify_build_environment is unimportant
Iterate over these directly rather than mapping first
Replace long conditional with guard clauses
Use each instead of while loop
Correct comment
Keg should link symlinks directly.

If the `src` in the Cellar of a formula is a symlink to another dir
in the same Cellar (for example `Frameworks/QtGui.framework` is a
symlink to `lib/QtGui.framework`), then we should make a symlink
directly instead of possibly creating an empty dir.

This is needed because Ruby's `find` does not follow symlinks (newer
versions can, but we have to support 10.8 for a long time).

Currently this probably only occurs for Qt, where we put symlinks
into the Cellar/Frameworks and the frameworks linking code is a bit
special to create a directory to "merge" together different versions
of the same framework from different formulae. See `python` and
`python3`; both install `Python.framework` and only one can be the
`Current` but the other should still be put into
`Python.framework/Versions`. Therefore `Python.framework` has to
be a dir and no symlink.