I think it is a concern, but I think it's one that's better addressed by
the aggressive unit testing we're doing.

Alex


On Tue, Sep 10, 2013 at 11:47 AM, Paul Kehrer <notifications@github.com>wrote:

> In cryptography/primitives/block/modes.py:
>
> > @@ -20,3 +20,13 @@ class CBC(object):
> >      def __init__(self, initialization_vector):
> >          super(CBC, self).__init__()
> >          self.initialization_vector = initialization_vector
> > +
> > +    def get_iv_or_nonce(self, api):
> > +        return self.initialization_vector
> > +
> > +
> > +class ECB(object):
> > +    name = "ECB"
> > +
> > +    def get_iv_or_nonce(self, api):
> > +        return api.get_iv_for_ecb()
>
> My thinking on ModeWithNoParameters was that if we had someone implement a
> mode and forget to register it to an ABC I didn't want the module to
> silently pass a null to the underlying encryptinit. I can remove it if
> people don't think that's a serious concern though.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alex/cryptography/pull/53/files#r6274793>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084