general commit before i split edshare_core