I will look at the instance you mentioned where its returning just userid ,
that might be able to be shortened or removed, as it appeared to be doing
an association which is unneeded now.


On Thu, Sep 19, 2013 at 7:01 PM, Cristina <notifications@github.com> wrote:

> In app/models/user.rb:
>
> > @@ -73,6 +73,8 @@ def has_no_credentials?
> >    has_many :skins, :foreign_key=> 'author_id', :dependent => :nullify
> >    has_many :work_skins, :foreign_key=> 'author_id', :dependent => :nullify
> >
> > +  has_many :tag_set_ownerships, :dependent => :destroy
> > +  has_many :tag_sets, :through => :tag_set_ownerships
>
> I may be wrong here, but it looks like the User should also have
> has_many :tag_set_nominations
>
> I know the pseud doesn't currently have this association specified on its
> side, and it is only specified on the TagSetNomination side (belongs_to
> :pseud), so it's probably not mandatory, just good practice.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/otwcode/otwarchive/pull/1336/files#r6476928>
> .
>