Hi John,

I have made all the changes according to the feedback except for the
following:

   - We're going to need to add default values to several columns on
   public.itemsite that aren't on the baseline orm. Do that in
   database/client/source/public/itemsite

So this should be accomplished with a BEFORE INSERT OR UPDATE trigger
function correct?

Thanks,
Julian


On Thu, Jan 24, 2013 at 8:03 AM, John Rogelstad <notifications@github.com>wrote:

> In client/orm/models/itemsite.json:
>
> > +          "type": "Number",
> > +          "column": "costcat_id",
> > +          "isPrimaryKey": true
> > +        }
> > +      },
> > +      {
> > +        "name": "code",
> > +        "attr": {
> > +          "type": "String",
> > +          "column": "costcat_code"
> > +        }
> > +      }
> > +    ],
> > +    "isSystem": true
> > +  },
> > +  {
>
> Got some work to do here. Most of these fields need to be removed, except
> the two listed below that should be added by a sales extension.
> Observations:
>
> Site is missing
> Item Site characteristics do not exist in the application
> Leave off:
> QtyOnHand (Internal only)
> EventFence (Std. Edition)
> Stocked (Inv)
> Freeze (internal only)
> Use Params (inventory)
> Sold Ranking (Added by Sales extension)
> Is Sold (Added by Sales extension)
> Create PR (Purchasing)
> Create WO (Manufacturing)
> Value (Internal Only)
> Supply Itemsite Id (Std. Ed.)
> Wo Supply (Mfg.)
> Po Supply (Purchasing)
> cos default (Accounting)
> Create SoPo (Sales/Purchasing)
> Drop Ship (Std. Edition)
>
> We're going to need to add default values to several columns on
> public.itemsite that aren't on the baseline orm. Do that in
> database/client/source/public/itemsite
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xtuple/database/pull/218/files#r2758341>.
>
>