Sorry I couldn't check the issues, I was travelling.
Regarding the REMOTE_ADDR, yes your concern is true. I suggest we can
change md5(microtime().$_SERVER[REMOTE_ADDR]) to
md5(microtime().$_SERVER[REMOTE_ADDR].rand()) This will reduce the
probabibility highly.


On Fri, Apr 26, 2013 at 9:35 AM, Gina Trapani <notifications@github.com>wrote:

> In webapp/_lib/class.Session.php:
>
> > @@ -71,10 +74,16 @@ public static function getLoggedInUser() {
> >       * @param Owner $owner
> >       */
> >      public static function completeLogin($owner) {
> > +		
> > +		$config = Config::getInstance();
> > +		$_SESSION[$config->getValue('source_root_path')]['session_key']=md5(microtime().$_SERVER[REMOTE_ADDR]) ;
>
> Is there a risk using REMOTE_ADDR here? Theoretically 2 people could log
> in at the exact same time from the same IP address and this wouldn't be
> unique.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ginatrapani/ThinkUp/pull/1564/files#r3971059>
> .
>



-- 
-- 
*Hemant Kumar Singh*
III Year,
B.E.(Hons) Chemical Engineering
M.Sc. (Hons) Physics
e-mail: *Gmail <unizen01@gmail.com> , BITSmail <f2010580@bits-pilani.ac.in>*

contact: +919529068585,+917891160904

*Birla Institute of Technology & Science,* Pilani

Pilani Campus, Rajasthan 333 031 02, INDIA