This module is separated from the common modules since it will contain all
the methods that can be done if we have got a root access, and about that
it contains one command, i it will be enhanced to include more commands


On Mon, Nov 18, 2013 at 11:14 PM, OJ Reeves <notifications@github.com>wrote:

> In lib/rex/post/meterpreter/extensions/android/root/root.rb:
>
> > +module Android
> > +module Root
> > +
> > +
> > +class Root
> > +
> > +  def initialize(client)
> > +    @client = client
> > +  end
> > +
> > +  def device_shutdown(n)
> > +    request = Packet.create_request('device_shutdown')
> > +    request.add_tlv(TLV_TYPE_SHUTDOWN_TIMER, n)
> > +    response = client.send_request(request)
> > +    return response.get_tlv(TLV_TYPE_SHUTDOWN_OK).value
> > +  end
>
> It seems a bit unnecessary to have a whole new module which contains just
> a single command like this. Not only that, but the name Root is a little
> counter-intuitive. In my opinion, the code in this module could be moved
> into the Common module and this module removed completely.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rapid7/metasploit-framework/pull/2174/files#r7739088>
> .
>