? unless params.empty?
add spec and nil check