Art, please take a look at the pull request when you have some time. I have made all of the changes you wanted, plus all of the alarm stuff and Laptime Summary updates are in there.

Keith




________________________________
 From: arthare <notifications@github.com>
To: arthare/wifilapper <wifilapper@noreply.github.com> 
Cc: KDJones2 <KDJones2@yahoo.com> 
Sent: Tuesday, March 19, 2013 5:19 AM
Subject: Re: [wifilapper] Fixed Value Display, now working!! (#17)
 

In PitsideConsole/PitsideConsole/PitsideConsole.cpp:
> @@ -1646,7 +1751,7 @@ class CMainUI : public IUI,public ILapSupplier
>    // lap display style data
>    map<const CExtendedLap*,int> m_mapLapHighlightTimes; // stores the highlight times (in milliseconds since phone app start) for each lap.  Set from ILapSupplier calls
>  
> -  LAPSUPPLIEROPTIONS m_sfLapOpts;
> +//  LAPSUPPLIEROPTIONS m_sfLapOpts;
>    LAPDISPLAYSTYLE m_eLapDisplayStyle; 
Really, you should leave this here.  it's really bad form to have global (and globally-accessible) values.  If you need to pass it to your plot prefs dialog, just pass it as &m_sfLapOpts.  If LapPainter needs to use it, it is already accessible via the lap options interface.  Since you kept the name as m_sfLapOpts, it shouldn't be too hard to switch it back to being owned by CMainUI rather than a global.
http://en.wikipedia.org/wiki/Global_variable
—
Reply to this email directly or view it on GitHub.