Thank you for the remark! I repaired it in my last commit. It was clearly
too late in the night when I revised it before... :)


On 5 October 2013 23:58, Willem Jan Palenstijn <notifications@github.com>wrote:

> In engines/avalanche/parser.cpp:
>
> > +		{50, "Passable"},    {65, "Good"},
> > +		{80, "Experienced"}, {108, "The BEST!"},
> > +		{32767, "copyright'93"}
> > +	};
> > +
> > +	for (int i = 0; i < 8; i++) {
> > +		if ((_vm->_dnascore >= kRanks[i]._score) && (_vm->_dnascore < kRanks[i + 1]._score)) {
> > +			return kRanks[i]._title;
> > +		}
> > +	}
> > +	return "";
> > +}
> > +
> > +Common::String Parser::totalTime() {
> > +	// There are 65535 clock ticks in a second, 1092.25 in a minute, and 65535 in an hour.
> > +	const double ticksInOneSec = (double)(65535) / 3600;
>
> No; since you're only using it in the line below where you're flooring it
> again, you can just merge these two lines into a single expression with
> only integer math. The comments are inconsistent internally and with the
> code, by the way.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scummvm/scummvm/pull/399/files#r6785110>
> .
>



-- 
Peter Bozsó