Hi Maurice,
CC: Luke, Dave, Tim, Carlos,

I have added the replace_data_process() method to add replace functionality to data process management service.

The ion def pull request is here: https://github.com/ooici/ion-definitions/pull/262/files

The coi-services pull request : https://github.com/ooici/coi-services/pull/495/files

Please review the pull requests and let me know if you would like me to make any changes.
If after review, the pull requests are found to be okay for merging, the ion defs pull request needs to be merged first.

Thanks,
Swarbhanu.



Swarbahnu
1. Can you verify that our data process and data process definition tests demonstrate the remove op? I think this is another place where we may want to augment the service interface to provide the correct sequence of steps that send events,  disconnect from the input stream, delete the output stream and then spin down the process. Please check with Luke on the correct approach for his transform process and transform functions.

2. For replace, I think there may be scenarios where a user would want to stop the data process, possibly edit the params or switch the input stream then relaunch. Again, I would check with Luke to see the best practice here for his transform framework.

3. We also need better testing of the transform tables. There is a test that demonstrates this capability but please verify that it is current, do a little performance testing as well as try different scenarios of how the table is attached and passed into the transform.

4. Chris W has been making progress on the data processes that are required for 2.1/ We will need to see what variations are required but you may want to experiment with some of the patterns that Michael has outlined<https://docs.google.com/drawings/d/1yhLJetOinVTrLEztqOe_w3lKXE_kJKSmArqHibDu29I/edit>, primarily the HA pattern and multi-input if they are ready.

I think we may run into a few issues as we dig into remove and replace logic. We can talk thru the orchestration steps but first see what works and what does not.

While creating or updating tests, think about how the services could be improved to facilitate these operations and reduce the effort for a marine operator to manage his assets. Also the tests should verify that the expected events are sent.

Please let me know about any questions or ideas to improve the service operations. Thanks.

Maurice

Maurice Manning
858.822.4433
mmmanning@ucsd.edu<mailto:mmmanning@ucsd.edu>