Code Cleanup: Calendar and Diary

.. comments just reflect current constraints and are not
actionable, so XXX removed.
Code Cleanup: Fix tools

All the fix tools share common code with an empty else
clause markeed with XXX. removed the redundant code.
Code Cleanup: CP chart
Code Cleanup: DBAccess

.. invalid comments about texts which are bwing stored.
Code Cleanup: GUI elements
Code Cleanup: Data processors

.. still call ride selected when done.
Code Cleanup: GcCalendarModel

.. wow, nasty memory leak fixed. Leaked memory every
time a ride was selected or calendar was refreshed!

.. tbf it was marked with a 'XXX' memory leak comment
but really lazy to leave it there.

.. was also highlighted by valgrind, which is promising,
since I've been using it to hunt down any memory managment
issues -- most of them are within 3rd party libraries tho.
Merge branch 'master' of github.com:/GoldenCheetah/GoldenCheetah
Code Cleanup: Notes deprecated

.. some vestiges from the old notes file.
.. fixes a significant memory leak in MainWindow too.
Code Cleanup: src.pro

Removed deprecated / unused code, includes;
- racedispatcher.cpp
- simplenetworkcontroller.cpp
- simplenetworkclient.cpp

Will look at the network stuff in OpenTrainer.
Code Cleanup: Deprecating stuff

Train view - race* - out of date and no used
Train view - SimpleNetwork - not used
Analysis view - WeeklySummaryWindow - not used
MainWindow - RideCalendar - deprecated 2 years ago
Code Cleanup: Deprecated

MainWindow - AthleteTool - not used.
Code Cleanup: Minor Valgrind grumbles

.. uninitialised variables
Code Cleanup: Valgrind Memory

Not sure why, but setting the text on a treewidget item seems to
cost a lot of memory. So we don't bother since it is never used.

In general the valgrind output is ok, quite surprised. There are
very few non-widget items that are alloced but never free'd in the
GC code.
Merge branch 'master' of github.com:GoldenCheetah/GoldenCheetah
Fix assert SEGV on Trimp Points

Introduced by me when using workout_time for duration.
Icon Toolbar Memory Management

More minor fixups regarding memory leaks.
Code Cleanup: ErgFile

.. XXX is a suggestion not a TODO.
Code Cleanup: Device Downloading

.. all comments are suggestions not mandatory and we have a feature
request system for that.
Code Cleanup: Charts

.. comments explain decisions, no action required.