Add CSS Variables files to visual studio project.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add CSS variables files to .pro makefile.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add CSS variables files to .am makefile.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add CSS variables files for wx port.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
        Windows build fix.

        * WebJavaScriptCollector.cpp: Added a missing include.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
        Reviewed by Darin.

        Get rid of some threadInstance calls.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::init):
        * kjs/Parser.cpp:
        (KJS::Parser::parse):
        * kjs/Shell.cpp:
        (jscmain):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-19  John Sullivan  <sullivan@apple.com>

        Rubber-stamped by Dan
        
        Prepended all FrameViewPrivate instance member variables with "m_" (in preparation
        for adding a new one in a future patch)

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::~FrameView):
        (WebCore::FrameView::resetScrollbars):
        (WebCore::FrameView::didFirstLayout):
        (WebCore::FrameView::initScrollbars):
        (WebCore::FrameView::layoutCount):
        (WebCore::FrameView::needsFullRepaint):
        (WebCore::FrameView::layoutRoot):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::scrollTo):
        (WebCore::FrameView::useSlowRepaints):
        (WebCore::FrameView::setUseSlowRepaints):
        (WebCore::FrameView::removeSlowRepaintObject):
        (WebCore::FrameView::setScrollbarsMode):
        (WebCore::FrameView::setVScrollbarMode):
        (WebCore::FrameView::setHScrollbarMode):
        (WebCore::FrameView::scheduleRelayout):
        (WebCore::FrameView::scheduleRelayoutOfSubtree):
        (WebCore::FrameView::layoutPending):
        (WebCore::FrameView::needsLayout):
        (WebCore::FrameView::unscheduleRelayout):
        (WebCore::FrameView::isTransparent):
        (WebCore::FrameView::setTransparent):
        (WebCore::FrameView::baseBackgroundColor):
        (WebCore::FrameView::setBaseBackgroundColor):
        (WebCore::FrameView::performPostLayoutTasks):
        (WebCore::FrameView::updateOverflowStatus):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-19  David Hyatt  <hyatt@apple.com>

        Implement some cleanup of CSS variables based off Darin's review comments.

        Reviewed by darin

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseVariable):
        (WebCore::CSSParser::checkForVariables):
        (WebCore::CSSParser::addUnresolvedProperty):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::addMatchedDeclaration):
        * css/CSSVariableDependentValue.h:
        * css/CSSVariablesRule.cpp:
        (WebCore::CSSVariablesRule::CSSVariablesRule):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-19  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin
        
        - fixed <rdar://problem/6021353> Assertion failure (!root->needsLayout()) after certain steps
        
        The didFirstLayout callback was called in a place where trouble would ensue if the client
        did any work that would cause the layout to be dirtied. Fixed by delaying the callback
        until performPostLayoutTasks.

        * page/FrameView.cpp:
        new m_firstLayoutCallbackPending instance member variable in FrameViewPrivate
        (WebCore::FrameViewPrivate::reset):
        set m_firstLayoutCallbackPending to false
        (WebCore::FrameView::layout):
        set m_firstLayoutCallbackPending instead of a local variable; don't do didFirstLayout callback here
        (WebCore::FrameView::performPostLayoutTasks):
        if m_firstLayoutCallbackPending is set, do didFirstLayout callback here, then clear m_firstLayoutCallbackPending



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-19  Alp Toker  <alp@nuanti.com>

        GTK+/autotools build fix. JSGlobalObject.cpp in now in
        AllInOneFile.cpp and shouldn't be built separately.

        * GNUmakefile.am:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-19  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin
        
        Tweak to previous checkin

        * page/FrameView.cpp:
        (WebCore::FrameView::performPostLayoutTasks):
        clear m_firstLayoutCallbackPending before performing callback, to avoid recursion



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-19  David Hyatt  <hyatt@apple.com>

        Fix out of bounds bug in CSSVariablesDeclaration's item() method.

        Reviewed by Sam, Darin

        * css/CSSVariablesDeclaration.cpp:
        (WebCore::CSSVariablesDeclaration::item):
        * css/CSSVariablesDeclaration.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-19  Dan Bernstein  <mitz@apple.com>

        Reviewed by Alexey Proskuryakov.

        - fix crash in CSSStyleDeclaration::copyPropertiesInSet()

        Covered by many editing tests

        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::copyPropertiesInSet): Re-ordered to avoid
        null pointer deref.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore:

2008-06-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <https://bugs.webkit.org/show_bug.cgi?id=19653>
        Typing style lost when creating list from, indenting or outdenting an empty paragraph
        
        There were two problems.  First, moveParagraphs didn't preserve the style of empty paragraphs.
        Second, indent, outdent and list creation returned false from preservesTypingStyle.
        The second problem couldn't be fixed by just adding preservesTypingStyle() { return true; }
        to those commands, though, because of other bugs.
        
        Cleaned up the implementation of typing style enough to remove FIXMEs for:
        
        <rdar://problem/3769899> Implementation of typing style needs improvement 
        
        which has actually been closed for some time now anyway.
        
        * dom/Document.cpp: Removed an unused header.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): Preserve the style of an empty paragraph, too.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::saveTypingStyleState): Removed FIXME.
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): 
        Removed FIXME.  
        If there is a typing style to apply after a delete, apply it to any line break that acts as a paragraph
        placeholder, not only one that was inserted by deletion.  This fixes a bug where deleting
        <div><b>Bold</b><br></div>, changing the selection and then coming back and typing wouldn't 
        produce bold text.  
        Don't set the EditCommand's typingStyle, it has been removed (more on that later).
        (WebCore::DeleteSelectionCommand::doApply): We don't need to pass calculateTypingStyleAfterDelete
        the inserted placeholder because it will find it.
        (WebCore::DeleteSelectionCommand::preservesTypingStyle): Normally deletion doesn't preserve the 
        typing style that was present before it.  For example, type a character, Bold, then delete the 
        character and start typing.  The Bold typing style shouldn't stick around.  We got this right before 
        purely by chance. Deletion should preserve a typing style that *it* sets, however.
        * editing/DeleteSelectionCommand.h: No longer need to pass calculateTypingStyleAfterDelete
        the inserted placeholder.
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply): 
        Clearing or not clearing a removed anchor should not be determined by whether or not a command 
        preservesTypingStyle().  For example, the deletion that removed an anchor (and stored it), may 
        not preserve the typing style, but that doesn't mean that it should then go and clear the removed 
        anchor.  All high level commands, and all commands that a TypingCommand spawns, except for
        text insertions, which should restore a removed anchor, should clear it.
        There is no longer a typing style on EditCommand, removed code that cleared it.  Code that clears the 
        *actual* typing style is now in Editor::appliedEditing, just like before.
        There is no longer a typing style on EditCommand, removed code to set one.
        (WebCore::EditCommand::styleAtPosition): Removed FIXME.
        * editing/EditCommand.h: 
        Removed code assosiated with m_typingStyle.
        Made preservesTypingStyle() public, so that we can call it from Editor::appliedEditing().
        * editing/Editor.cpp:
        (WebCore::Editor::appliedEditing):
        Removed code to preserve the removedAnchor during the call to setSelection, because we no longer
        request to clear the typing style with that call.  Also removed the FIXME about this.
        Before, a command would set the Frame's typing style by setting its own typingStyle, and then 
        letting code here, in appliedEditing pick that up and set it on the Frame.  Now, the command 
        itself sets the Frame's typing style.  Deletion is the only command that does this right now.
        * editing/IndentOutdentCommand.h:
        (WebCore::IndentOutdentCommand::preservesTypingStyle): Added, returns true.
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply): Removed FIXME.
        * editing/InsertListCommand.h:
        (WebCore::InsertListCommand::preservesTypingStyle): Added.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Removed FIXME.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input): Removed FIXME.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Removed FIXME and also added one about clearing
        the typing style here.  It seems like it's something that could wait until after the command
        has been performed, since there is no code between this point and the end of the operation
        that queries or uses the typing style.

LayoutTests:

2008-06-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.
        
        https://bugs.webkit.org/show_bug.cgi?id=19653
        Typing style lost when creating list from, indenting or outdenting an empty paragraph

        These demonstrate fixes:
        * editing/execCommand/19653-1-expected.txt: Added.
        * editing/execCommand/19653-1.html: Added.
        * editing/execCommand/19653-2-expected.txt: Added.
        * editing/execCommand/19653-2.html: Added.
        * editing/execCommand/19653-3-expected.txt: Added.
        * editing/execCommand/19653-3.html: Added.
        * editing/execCommand/19653-4-expected.txt: Added.
        * editing/execCommand/19653-4.html: Added.
        Changed to an equivalent but more bloated DOM because of a pre-existing bug in ApplyStyleCommand:
        * platform/mac/editing/deleting/delete-br-011-expected.txt:
        Fixed a bug where the typing style wasn't applied to the placeholder in an empty paragraph,
        so typing would create text with the right style, but if you were to change the selection
        and then come back and start typing, the style would be wrong.  The size of the caret was
        also wrong as a result:
        * platform/mac/editing/deleting/delete-br-012-expected.txt:
        * platform/mac/editing/deleting/delete-br-012-expected.png:
        * platform/mac/editing/deleting/delete-br-012-expected.checksum:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore:

2008-06-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.

        <https://bugs.webkit.org/show_bug.cgi?id=16049>
        execCommand('backColor') fails on collapsed selections

        * editing/EditorCommand.cpp:
        (WebCore::CommandEntry::): Enable BackColor for caret selections, and
        disable ForeColor in plaintext-only regions.

LayoutTests:

2008-06-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.
        
        <https://bugs.webkit.org/show_bug.cgi?id=16049>
        execCommand('backColor') fails on collapsed selections

        * editing/execCommand/16049-expected.txt: Added.
        * editing/execCommand/16049.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore:

        Reviewed by John Sullivan.

        - fix a bug where anonymous tables were inserted in the wrong place

        Tests: tables/mozilla/bugs/bug2479-2.html
               tables/mozilla/bugs/bug278266.html
               tables/mozilla/bugs/bug8411.xml

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::addChild): Changed to create an anonymous
        table and insert it before beforeChild unless the insertion point is
        right after an existing anonymous table, in which case the existing
        table is used.

LayoutTests:

        Reviewed by John Sullivan.

        - updated tests and results after fixing a bug where anonymous tables were inserted in the wrong place

        * fast/forms/form-hides-table.html: Wrapped every case in a block in
        order to prevent cross-talk.
        * platform/mac/fast/forms/form-hides-table-expected.checksum:
        * platform/mac/fast/forms/form-hides-table-expected.png:
        * platform/mac/fast/forms/form-hides-table-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.png: Added.
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
        * platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug278266-expected.checksum: Added.
        * platform/mac/tables/mozilla/bugs/bug278266-expected.png: Added.
        * platform/mac/tables/mozilla/bugs/bug278266-expected.txt: Added.
        * platform/mac/tables/mozilla/bugs/bug8411-expected.checksum: Added.
        * platform/mac/tables/mozilla/bugs/bug8411-expected.png: Added.
        * platform/mac/tables/mozilla/bugs/bug8411-expected.txt: Added.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.png: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.checksum: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.png: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.txt: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.checksum: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.png: Removed.
        * platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.txt: Removed.
        * platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
        * tables/mozilla/bugs/bug2479-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-2.html.
        * tables/mozilla/bugs/bug278266.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug278266.html.
        * tables/mozilla/bugs/bug8411.xml: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug8411.xml.
        * tables/mozilla_expected_failures/bugs/bug2479-2.html: Removed.
        * tables/mozilla_expected_failures/bugs/bug278266.html: Removed.
        * tables/mozilla_expected_failures/bugs/bug8411.xml: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
        Reviewed by Geoff.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
        Reviewed by Sam Weinig.

        - two more updated results for the last patch

        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
        * platform/mac/fast/invalid/020-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-19  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Timothy Hatcher.

        Introduce compiler define for MinGW, to have COMPILER(MINGW).

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2008-06-20  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=19082
        [Qt] Full-page plugins not activated

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34687 268f45cc-cd09-0410-ab3c-d52691b4dbfc