we probably want to encodeURIComponent these