update method signature
tests