On 11/07/2013 01:46 PM, Gareth Aye wrote:
>
> I'm not as familiar with the message splice stuff, but I feel like 
> this isn't all of the cases we need? Anyway it doesn't hurt to call 
> |emitHasSiblingEvents| after we add things even if nothing has changed :)
>

I'm not sure what you mean in terms of all of the cases.  Since it's 
just a boolean indicator of whether there's an adjacent message, we 
really only need to notify when there's a chance in the value, and that 
only happens when the message is at either end of the list of messages.

I do agree that the only harm is (minimal; DOM state should be the same, 
although there might be slight dirtying) performance harm, and if we 
just make sure to only call it outside of the loop, that probably should 
be fine.  And that's probably the right call from a complexity 
perspective.  And once we fix our batching situation, the performance 
hit should be reduced.