init: Check if running if not configured to start.

The reasoning for this is explained in:
https://projects.puppetlabs.com/issues/23033

Currently the init-script does not actually check if we're running and
return accordingly when status is called if the puppet master is not
configured to start.

This causes it to always return 0, meaning we're actually running
regardless of if that is the case.
Maint: Reformat docs for Augeas type's "changes" attribute

I'm trying to get DL elements out of the docs, and this fragment works better as
a more compact list anyway.
Maint: Reformat indirection reference to use H4s instead of DLs for termini

A long time ago, I shortsightedly decided to use the definition list Markdown
extension in some of our docs. Time and the renderer ecosystem haven't been kind
to that syntax, so we need to get away from them if we want to be able to switch
relatively freely between various MD processors.

This commit removes them from the last embedded documentation that we still use.
The old-style type reference still uses them, but since we've stopped relying on
it and moved to our own implementation, that should be fine.
(#23085) Ensure old puppet agents get properly stopped when upgrading from 2.6 or early to 2.7 or later
(#22925) Correct transposed arguments for assert_match

The assert_match expects search string/regex first, string to search
second.  We had them backwards.
Merge branch 'issue/master/22925-fix-assert-match-for-cached-catalog-test'

* issue/master/22925-fix-assert-match-for-cached-catalog-test:
  (#22925) Correct transposed arguments for assert_match
(maint) Honor TEST or TESTS and timesync when provisioning

Harness indicated you should set TESTS to override beaker --tests, but
was only looking at ENV['TEST'].  Accepts either TEST or TESTS now.

Also sets :timesync => true in base beaker options, replacing the :ntp
setting which can only be passed as a command line flag.  So beaker will
now perform ntpdate or equivalent on new hosts.
Merge pull request #2040 from jpartlow/maint/stable/acceptance-harness-tests-env-and-timesync

(maint) Honor TEST or TESTS and timesync when provisioning
Merge remote-tracking branch 'upstream/stable'

* upstream/stable:
  (maint) Honor TEST or TESTS and timesync when provisioning
(#23074) Do not expect rebuild during cert signing

The removal of rebuilding the inventory during certificate signing to
remove a race condition caused an acceptance test to break. The break is
not about an intrinsic part of the test and so the assertion has simply
been removed.
Merge pull request #2041 from zaphod42/issue/master/23074-no-longer-rebuild-during-signing

(#23074) Do not expect rebuild during cert signing
(packaging) Update PUPPETVERSION to 3.3.2
Maint: Change "installation" section of README to be more useful

- Point to PE
- Point to open source installation guide
- Point to running-from-source guide
Merge pull request #2042 from nfagerlund/readme_update

Maint: Change "installation" section of README to be more useful
(#23086) Ensure that failed_because events have a name

The name of an event is assumed to exist for any reports that are not
created by the inspect command. The inspect command constructs its
reports itself and does not currently use failed_because(). Therefore it
should be safe (if sad-making) to have *only* failed_because() set a
specific name on the event it creates.
Merge pull request #2043 from zaphod42/issue/master/23086-no-name-attribute-if-failed_because

(#23086) Ensure that failed_because events have a name
(#23096) Treat ENC classes with empty params as if they had no params

(PE-455)

Previously, all classes specified by an ENC in parameterized format (a
hash from class to a hash of its parameters) would be evaluated as if
they had parameters. This causes a failure if the class is already
included elsewhere.

This also caused classes with empty parameters to conflict, just because
they happened to be sent as if they were parameterized. For ENCs which
always submit classes in the parameterized form, this causes strange
errors even though there isn't any real conflict, and substantially
diminishes the utility of the ENC.

With this change, ENC classes which have no parameters won't conflict
if they are already included. Classes which do have parameters continue
to conflict the same as they did before, as do classes which are
declared in Puppet code without parameters using resource syntax.

Conflicts:
	spec/unit/parser/compiler_spec.rb

Resolved in favor of 64ff835, removing two specs which had been later
modified in favor of the introduced specs for 'when evaluating node
classes'.
(#23096) Remove redundant hash conversion when handling ENC classes

(PE-455)
Merge tag '3.3.2'

3.3.2

* tag '3.3.2':
  (packaging) Update PUPPETVERSION to 3.3.2
(maint) Reorganize data_binding/hiera-spec.rb

Gather helper methods, tests together for clarity.