Fixes inconsistency in flavors list with marker

Flavors list with marker is supposed to use flavorid as the marker since this is
the only id attribute the users can see, but it was using id (the confusion was
probably caused by the fact that flavorid attribute shows up to the user as id).

The change on db unit test shows makes the bug evident, and justify the changes
on the filter_by criteria.

Fixes bug 1226698

Change-Id: I3ffa636febb63be796fffc94be6486bf74e8239b
VMware: fix regression attaching iscsi cinder volumes

VMware drivers fail to attach a iSCSI backed cinder volume with an
error 'unable to find iscsi targets' because the underlying
retrieval api was updated to a newer version but not it's usage in
volume_util (see commit e331287cdd1300878bfb9bbb3630889370e5fa72).
This is a regression over Grizzly release.

Fixes: bug #1193980

Change-Id: Ic2d1dc800fa10295a4d7312fbeeaa0e16d792755
Add test_instance_get_active_by_window_joined

This adds a unit test for previous untested method
nova.db.sqlalchemy.instance_get_active_by_window_joined

Change-Id: Ib5826b34bba8e93d2966963c696a20df29501771
compute api should throw exception if soft reboot invalid state VM

When user perform soft reboot to a VM which in suspended/paused/
stopped/error state, nova compute api should throw exception for
such state.

Change-Id: Ic365c6360f6b7407d9de0dac6ff1093484692cf4
Closes-Bug: #1236930
Fix vmwareapi driver get_diagnostics calls

The vmware driver is calling vmops.get_info for both the get_info and
get_diagnostics APIs which is wrong since they should be returning
different information.  Given the hypervisor support matrix doesn't list
the vmware driver as supporting the nova diagnostics API, it seems this
was just an oversight.

This patch changes the driver code to call the vmops.get_diagnostics
method which raises NotImplementedError.  It also fixes the tests to
actually ensure covers get_diagnostics for both the ESX driver and the
VC driver.

Closes-Bug: #1237622

Change-Id: I0c9015f1f7d5dd219548196de479e87e878ea0fd
Imported Translations from Transifex

Change-Id: Ic8c3db69dde877030740a0a0df8e2f341addde34
Merge "Add test_instance_get_active_by_window_joined"
Merge "Imported Translations from Transifex"
Merge "VMware: fix regression attaching iscsi cinder volumes"
Merge "compute api should throw exception if soft reboot invalid state VM"
Merge "Fix vmwareapi driver get_diagnostics calls"
Merge "Fixes inconsistency in flavors list with marker"