Hi Bill,

Thanks for the feedback! I figured my use of QSerialPort wasn't optimal,
it's kind of brute force. I was getting some weird results. Thanks for the
tip, I'll take a look at SerialLink.cc and see about making it work better.
Up to now, I've been testing on Linux. I'm actually trying to get set up on
OSX so I can test it there, but the Qt Creator I downloaded seems like it's
not complete. It has little idea what to do with APM planner's project
file.

Odd about the scrolling. I'm not sure why a listview control would not
scroll. I assumed a listview in a framework like Qt would already scroll,
but perhaps not. Should be easy to fix. I'll take a look at that too.

As far as code standards go, yes, definitely let me know your preference
here. I've kind of taken the approach of imitating whatever style I find
myself in the middle of, and just winging it otherwise.

Anyway, thanks again.



On Sat, Nov 2, 2013 at 5:43 PM, Bill Bonney <notifications@github.com>wrote:

> In src/ui/configuration/LogConsole.h:
>
> > +    void selectNoneClicked();
> > +    void stopClicked();
> > +    void pullSelectedClicked();
> > +    void eraseLogsClicked();
> > +    void refreshClicked();
> > +    void listItemCheckChanged();
> > +    void readData();
> > +    void dumpError(QString);
> > +    void dumpFileStart(QString);
> > +    void dumpFileFinish(QString);
> > +    void dumpFileBytesRead(long);
> > +    void workerStopped();
> > +
> > +private:
> > +    Ui::LogConsole *ui;
> > +    QSerialPort *m_serial;
>
> Consider using guard pointers as they are set to null atomically on
> deletion see QPointer and the referenced counted version QSharedPointer
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/diydrones/apm_planner/pull/57/files#r7389044>
> .
>