The action seems to be geared for if you want more than one thing to be
possible or to handle the two actions substantially differently.  To me the
boolean makes sense as that isn't the case here, but obviously defer to
your judgement.


On Wed, May 22, 2013 at 12:16 PM, sinn3r <notifications@github.com> wrote:

> In modules/auxiliary/gather/coldfusion_pwd_props.rb:
>
> > @@ -43,7 +44,8 @@ def initialize(info = {})
> >
> >  		register_options(
> >  			[
> > -				Opt::RPORT(8500),
> > +				Opt::RPORT(80),
> > +				OptBool.new('CHECK', [false, 'Only check for vulnerability', false]),
>
> Instead of OptBool, I recommend using "Actions". Here's an example:
>
> https://github.com/rapid7/metasploit-framework/blob/master/modules/auxiliary/scanner/http/http_put.rb
>
> Let me know what you think.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rapid7/metasploit-framework/pull/1855/files#r4343607>
> .
>