move params into params class. gh-2