ARB_texture_view: Add multisample texture target testing

The "targets"  test is extended to include testing of
GL_TEXTURE_2D_MULTISAMPLE and GL_TEXTURE_2D_MULTISAMPLE_ARRAY.
This will test making valid and invalid texture views of these two
multisample targets and ensuring the correct GL error is set.

Reviewed-by: Brian Paul <brianp@vmware.com>
Signed-off-by: Jon Ashburn <jon@lunarg.com>
Add a "Contributing Patches" section to the HACKING file.

Reviewed-by: Brian Paul <brianp@vmware.com>
Add a comment to HACKING describing the use of "*-by" in commit messages.

Suggested-by: Frank Henigman <fjhenigman@google.com>
Reviewed-by: Frank Henigman <fjhenigman@google.com>
More comprehensive test for alpha blending with multisampling.

This test validates a corner case of the fix for
https://bugs.freedesktop.org/show_bug.cgi?id=53077 ([IVB] Output error
with msaa when both of framebuffer and source color's alpha are not
1).  Specifically, it verifies that the first time alpha blending is
used on a multisampled framebuffer, the contents of the framebuffer
are properly preserved.

v2: Make num_samples a command-line parameter.

Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
core.Environment: squash pylint warnings

This adds Environment.options = None, so that pylint will stop
complaining. This doesn't change any functionality at all.

Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Revert "summary.py: Treat subtests as groups"

This reverts commit e0d4bdbaa38a7441b0f38e115bd2daf3c6a05da3.
Revert "core.py: don't write subtests as full entries"

This reverts commit e8bfd585f0df4c9fb49080f19fb8c33a820733b2.
cl: Add a test for clEnqueueCopyBuffer v2

v2:
  - Remove redundant memcpy
  - Pass CL_MEM_READ_WRITE to piglit_cl_create_buffer()

Reviewed-by: Aaron Watry <awatry@gmail.com>
piglit-run.py: record whether the test run was concurrent

cc: ben@bwidawsk.net
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed by: Kenney Phillis <kphillisjr@gmail.com>
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
piglit-run.py: resume honors saved concurrency flag

This breaks incomplete runs started before applying the previous patch
in this series, since there will be no key for concurrency

v2: - Add this patch (Damien Lespiau)

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed by: Kenney Phillis <kphillisjr@gmail.com>`
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
piglit-run.py: Cleanups

This patch tidies up a few things, and lays groundwork for later patches
in this series.

Reviewed by: Kenney Phillis <Kkphillisjr@gmail.com>
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
piglit-run.py: Record all attributes of Environment and restore them

This causes all attributes in the Environment instance env to be dumped
into the json and reloaded on a resume. It adds an __iter__ magic method
to core.Environment to allow this.

Reviewed by: Kenney Phillis <Kkphillisjr@gmail.com>
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Split resume functionality out of piglit-run.py

The resume functionality actually shares only a little boilerplate with
the run functionality, and there is a lot of extra boilerplate that
exists (or should exist) to make resumes work correctly with all of the
command line options allowed by piglit-run. Therefore, it makes more
sense to split it out into it's own file.

Reviewed by: Kenney Phillis <Kkphillisjr@gmail.com>
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
draw-range-elements-base-vertex: Require GLSL 1.30.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Brian Paul <brianp@vmware.com>
gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS
summary: fix regression and fixes summaries

Somebody broke this.
core: don't report warn if stderr is not empty

The usefulness of this is questionable to say the least.

Acked-by: Eric Anholt <eric@anholt.net>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>