forgot committing global_def