Low: anything: do not remove the pidfile before testing the status
build: replace mkinstalldirs with INSTALL -d for consistency

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
build: remove old BSD cruft.

Checked on FBSD9, no init scripts are shipped with .sh extension

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
build: use AM_CPPFLAGS vs INCLUDE

INCLUDE has been obsolted and spits out a lot of warnings

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
build: fix lack of AC_LANG_SOURCE warnings at autogen time

configure.ac:112: the top level
configure.ac:693: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is expanded from...
../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is expanded from...

solution is to check compiler features via CPP (faster than compiling code)
and define AC_LANG_SOURCE for libnet build test.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
Merge pull request #345 from fabbione/build_fixes

Build fixes
Merge pull request #338 from dmuhamedagic/anything-pidtest

Low: anything: do not remove the pidfile before testing the status
[low] use_findmnt should accept 0 to disable findmnt

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
[high] workaround broken mount helpers that add / to device in /proc/mounts

otherwise findmnt can't find the mount point... joy!

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
[low] be consistent across fs agents and available options

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
Merge pull request #352 from fabbione/mountfixes

Mountfixes
Med: pgsql: Support for non-standard port and library locations

pgsql Resource Agent does not account for custom lib locations and
custom ports, making it impossible to use with some Postgres
installations.

Both of these customizable Postgres installation options are typically
controlled by simple environment variables, making them easy to
parametrize as
part of the Resource Agent (LD_LIBRARY_PATH and PG_PORT, respectively).
Merge pull request #349 from krig/bnc846449

Med: pgsql: Support for non-standard port and library locations
High: tomcat: Detect start script location

Some distros do not ship the catalina.sh script
as the script used to launch tomcat.   This patch
attempts to detect alternate locations and allows
user defined start script locations to be used.
Medium: slapd: find the correct default slapd config in fedora
Low: tomcat: Put default pid file location on temporary storage

Pid files always need to be put on storage that
is refreshed after reboot. Otherwise we run the risk
of a resource's stale pid file matching some other
process when pacemaker (or some other cluster manager) is
probing the resource for activity. This can result in
unrelated processes being killed in an effort to stop
a tomcat instance that is not actually present on the system.
Medium: tomcat: Avoid race condition in reading pid file on stop
High: tomcat: Avoid unnecessary force kill of tomcat on stop

If the catalina.sh script is not used to start and stop
tomcat, the stop action may return before the pid has
actually exited. This results in an unnecessary kill
on the pid to occur when it would have exited on its own
had we honored the stop timeout value.
Merge pull request #354 from davidvossel/tomcat_fixes

Various tomcat agent fixes
Merge pull request #356 from davidvossel/slapd_fixes

Medium: slapd: find the correct default slapd config in fedora