I'm still trying to work out what I want this class to do, but right now,
these are the pieces of information that I want the class to provide. I do
however expect the nomenclature to change.


On Wed, Dec 11, 2013 at 9:19 AM, Shaun Edwards <notifications@github.com>wrote:

> In
> industrial_extrinsic_cal/include/industrial_extrinsic_cal/calibration_job.hpp:
>
> > +  void clear();
> > +  bool add_observation(Camera_Observations CO, int frame_index);
> > +  int numb_camera_frames(); /** each camera frame has 6dof */
> > +  int numb_target_frames(); /** each target frame has 6dof */
> > +  int numb_unique_point_locs(); /** each unique point has 6dof, (some targets are unique points) */
> > +  int numb_uv_observations();
> > +  int total_parameters(){
> > +    return(num_camera_frames()*6 + num_target_frames()*6 + num_unique_point_locs()*3);
> > +  }
> > +  ;/** @brief finds the number of free parameters represented  */
> > +private:
> > +
> > +}
> > +
> > +class CalibrationJob{
> > +public:
>
> There are a lot of public methods here. Consider making most of them
> private or splitting the class.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ros-industrial/industrial_calibration/pull/2/files#r8269334>
> .
>