On Fri, Oct 25, 2013 at 11:14 PM, Hadley Wickham
<notifications@github.com>wrote:

> In R/test-files.r:
>
> >  #' @export
> >  test_dir <- function(path, filter = NULL, reporter = "summary", env = NULL) {
> > -  reporter <- find_reporter(reporter)
> > +  current_reporter <- find_reporter(reporter)
>
> I wonder if this should be optional - i.e. maybe reporter should default
> to c("summary", "list") and then find_reporter would return a
> multireporter if there were more than one inputs.
>
It makes things more complex, because I have to call a non-Reporter method
"lister$start_file(fname)" on the particular lister reporter.
Or we can add this method to Reporter...
But what would be the use case ?
Another thing that could be done, is to add the lister features into the
Reporter base class. But many reporters do not properly call the overridden
methods witl callSuper()


—
> Reply to this email directly or view it on GitHub<https://github.com/hadley/testthat/pull/98/files#r7228642>
> .
>