Not really - he did not pass the new encoding to the String constructor 
(and vice versa in the other place I commented).

I still don't understand why we have to convert a string into another 
string.  Why not from ByteBut to String or something similar?

On Wed 08 May 2013 01:35:17 PM KST, Norman Maurer wrote:
> In
> src/main/java/org/jboss/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java:
>
> > @@ -726,6 +726,24 @@ private String encodeAttribute(String s, Charset charset)
> >      }
> >
> >      /**
> > +     * Encode one attribute
> > +     * @return the encoded attribute
> > +     * @throws ErrorDataEncoderException if the encoding is in error
> > +     */
> > +    private String encodeAttributeMultipart(String s, Charset charset)
> > +            throws ErrorDataEncoderException {
> > +        if (s == null) {
> > +            return "";
> > +        }
> > +        try {
> > +            String encoded = new String(s.getBytes(charset.name()));
>
> looks good now...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/netty/netty/pull/1342/files#r4128091>.
>

--
https://twitter.com/trustin
https://twitter.com/trustin_ko
https://twitter.com/netty_project