Fix form field visibility/submission permissions. Close #744

* customforms::get_custom_form_fields() wasn't honoring the
  action type: submit/view
Fix #906 - make form_field.field_default TEXT column

Also make ispublic fields match role_id otherwise we get errors for role_id
greater that 127
Remove unneeded output in submit_custom_forms view

Makes this match whats loaded in admin/manage/forms/main view
Fix custom form fields permissions issues #695

* Form field mismatch function wasn't returning sane results, rewritten
to join to the roles table as other customforms queries do.
* Field validation was checking role id against access_level. Fix to compare
access level with access level
* Fix 'view only' fields in edit to actually have data
Fix display of custom fields in admin - remove float
Make members report edit user submit_custom_forms view like admin #965
Clean up: remove commented code and unused fn

* Remove commented code in customforms::get_edit_mismatch()
* Remove customforms::view_everything() rather than fix the logic
Merge pull request #1062 from rjmackay/custom-forms-fixes

Custom forms fixes