Updated code that mounts an NFS share: Added ability to interpret a CIFS URL share -> E.g. cifs://[<domain>\\]<user>:<password>/<devicepath> Added error handling. -> Previously mount failed siliently, albeit with logging. -> Now, mount failure returned to caller. Refactored code -> Removed duplicate code to simplify test coverage -> Removed unused return values. Improve logging -> Provide better indication of step that failed.
Add unit and functional tests that test ability to mount a cifs share.
Refactor code to allow tests to inject dependencies. Revise format for encoding a cifs share as a URI: user,passwork and any other mount parameters specified with the -o flag are passed as query parameters.
Provide means to override hardcoded values using agent.properties
Allow tests to be turned on using -DskipTests=false Include log4j.xml that provides logging configuration for tests. log4j.xml is the file that the log4j uses by default. the pom.xml has been updated to identify its location.
Update discoverer to recognise a URI that uses the cifs scheme and to use the same ServerResource for cifs as it would for nfs
Update so that when a cifs scheme is provided, the functionality is the same as if an nfs scheme uri were provided.:wq
Add "cifs" equivalent to list of DataStoreProtocol types. This enum is sometimes used in place of string literals when checking a datastore's scheme. However, whereDataStoreProtocol is used, checks for CIFS would not be appropriate at this time.
Centralise validation code for cifs URLs. Allows error messages to be written once and logged as warning. Error handling decisions made by caller. E.g. caller may want to throw a specialised exception type.
Make use of UriUtils.java methods to validate cifs URIs
Make use of UriUtils.java methods to validate cifs URIs
Make use of UriUtils.java methods to validate cifs URIs Add code to create database entry for CIFS primary storage. Query parameters are placed in the userInfo field.
Treat cifs uri as you would an nfs uri
Don't validate against a URI encoded URI.
Remove cache bypass when using Hyperv, because CIFS
 storage can be used for staging. Change checks for
 "nfs" ImageStoreEntity protocol to accept "cifs"
Merge remote-tracking branch 'origin/master' into cifs_support
Eclipse is expanding wildcard imports and alphabetising.  Revert to old
list to fix build.