Revert "libffi 3.0.12"

This reverts commit 2efe718a3b4b5e124004fdbb68cc13da5c8de41c.
libffi: note why we reverted
Adding libmodbus.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
libmodbus 3.0.3

Closes #18263.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
bash 4.2.45
wireshark 1.8.6
Python: update pip and distribute

Closes #18358.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
clozure-cl 1.9

Closes #18351.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
sshpass: add to blacklist.

We keep rejecting this again and again.

See discussion in #9577, #12941, #13855.

Closes #18332.
audit: correct inverted has_trailing_newline condition

has_trailing_newline? checked if formula did not have a trailing
newline. Invert regex and invert audit check.

Closes #18359.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Index pkgconfig directories by MacOS.version
Exclude global pkgconfig dirs under superenv
bottles: remove unused 'version' from DSL.
Warn on bottles skipped due to non-default Cellar.

Closes #18333.
Add pkgconfig dirs for all deps under superenv

Fixes #18367.
Rename these collections for clarity
Use attr_accessor to suppress warning
Fix tests under 32-bit SL
Adjust BOTTLE_EXTNAME_RX for :snow_leopard_32
tests: allow setting MACOS_VERSION from the environment

This makes it easy to test things that vary depending on this constant
without editing testing_env.rb.